Skip to content
This repository was archived by the owner on Apr 17, 2019. It is now read-only.

Commit 515b90f

Browse files
authored
Merge pull request #1199 from lavalamp/ff5
fix UI for flakes & nonblocking suites
2 parents 6e090ac + cc5c7df commit 515b90f

File tree

1 file changed

+41
-14
lines changed

1 file changed

+41
-14
lines changed

mungegithub/submit-queue/www/script.js

Lines changed: 41 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -186,20 +186,47 @@ function SQCntl(dataService, $interval, $location) {
186186
'name': key,
187187
'id': job.ID,
188188
};
189-
if (job.Status == 'Stable') {
190-
// green check mark
191-
obj.state = '\u2713';
192-
obj.color = 'green';
193-
} else if (job.Status == 'Not Stable') {
194-
// red X mark
195-
obj.state = '\u2716';
196-
obj.color = 'red';
197-
failedBuild = true;
198-
} else {
199-
obj.state = 'Error';
200-
obj.color = 'red';
201-
obj.msg = job.Status;
202-
failedBuild = true;
189+
switch (job.Status) {
190+
case 'Stable':
191+
// green check mark
192+
obj.state = '\u2713';
193+
obj.color = 'green';
194+
break;
195+
case 'Not Stable':
196+
// red X mark
197+
obj.state = '\u2716';
198+
obj.color = 'red';
199+
failedBuild = true;
200+
break;
201+
case 'Ignorable flake':
202+
// orange X mark
203+
obj.state = '\u2716';
204+
obj.color = 'orange';
205+
obj.msg = 'Flake!';
206+
break;
207+
case '[nonblocking] Stable':
208+
// green check mark
209+
obj.state = '\u2713';
210+
obj.color = 'green';
211+
obj.msg = '[nonblocking]';
212+
break;
213+
case '[nonblocking] Not Stable':
214+
// orange X mark
215+
obj.state = '\u2716';
216+
obj.color = 'orange';
217+
obj.msg = '[nonblocking]';
218+
break;
219+
case '[nonblocking] Ignorable flake':
220+
// orange X mark
221+
obj.state = '\u2716';
222+
obj.color = 'orange';
223+
obj.msg = '[nonblocking]';
224+
break;
225+
default:
226+
obj.state = 'Error';
227+
obj.color = 'red';
228+
obj.msg = job.Status;
229+
failedBuild = true;
203230
}
204231
obj.stability = '';
205232
result.push(obj);

0 commit comments

Comments
 (0)