add unit test for auto prioritize

Author: freehan

mungegithub/mungers/flake-manager.go

@@ -307,7 +307,7 @@ func autoPrioritize(comments []libgithub.IssueComment, issueCreatedAt *time.Time
 	weekCount := 0
 
 	for _, c := range comments {
-		// TODO: think of a better way to identify flake comments 
+		// TODO: think of a better way to identify flake comments
 		// "Failed:" is a special string contained in flake issue filed by flake-manager
 		// Please make sure it matches the body generated by IssueSource.Body()
 		if !sync.RobotUser.Has(*c.User.Login) || !strings.Contains(*c.Body, "Failed:") {
@@ -327,9 +327,9 @@ func autoPrioritize(comments []libgithub.IssueComment, issueCreatedAt *time.Time
 
 	// P2: By default
 	// P1: Flake happens more than once in last month.
-	// P0: Flake happens more than once in last week.
+	// P0: Flake happens more than twice in last week.
 	p := sync.PriorityP2
-	if weekCount >= 2 {
+	if weekCount >= 3 {
 		p = sync.PriorityP0
 	} else if monthCount >= 2 {
 		p = sync.PriorityP1

mungegithub/mungers/flake-manager_test.go

@@ -20,9 +20,12 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/google/go-github/github"
+	github_testing "k8s.io/contrib/mungegithub/github/testing"
 	cache "k8s.io/contrib/mungegithub/mungers/flakesync"
 	"k8s.io/contrib/mungegithub/mungers/sync"
 	"k8s.io/contrib/test-utils/utils"
+	"time"
 )
 
 func makeTestFlakeManager() *FlakeManager {
@@ -82,3 +85,70 @@ func TestBrokenJobSource(t *testing.T) {
 	expect(t, source.Title(), "e2e-gce: broken test run")
 	checkCommon(t, &source)
 }
+
+func flakecomment(id int, createdAt time.Time) github.IssueComment {
+	return github_testing.Comment(id, "k8s-bot", createdAt, "Failed:")
+}
+
+func TestAutoPrioritize(t *testing.T) {
+	testcases := []struct {
+		comments       []github.IssueComment
+		issueCreatedAt time.Time
+		expectPriority int
+	}{
+		// New flake issue
+		{
+			comments:       []github.IssueComment{},
+			issueCreatedAt: time.Now(),
+			expectPriority: 2,
+		},
+		{
+			comments: []github.IssueComment{
+				flakecomment(1, time.Now()),
+			},
+			issueCreatedAt: time.Now().Add(-1 * 29 * 24 * time.Hour),
+			expectPriority: 1,
+		},
+		{
+			comments: []github.IssueComment{
+				flakecomment(1, time.Now()),
+				flakecomment(1, time.Now().Add(-1*3*24*time.Hour)),
+				flakecomment(1, time.Now().Add(-1*6*24*time.Hour)),
+			},
+			issueCreatedAt: time.Now().Add(-1 * 30 * 24 * time.Hour),
+			expectPriority: 0,
+		},
+		{
+			comments: []github.IssueComment{
+				flakecomment(1, time.Now()),
+				flakecomment(1, time.Now().Add(-8*24*time.Hour)),
+			},
+			issueCreatedAt: time.Now().Add(-1 * 29 * 24 * time.Hour),
+			expectPriority: 1,
+		},
+		{
+			comments: []github.IssueComment{
+				flakecomment(1, time.Now()),
+				flakecomment(1, time.Now().Add(-8*24*time.Hour)),
+				flakecomment(1, time.Now().Add(-15*24*time.Hour)),
+				flakecomment(1, time.Now().Add(-20*24*time.Hour)),
+			},
+			issueCreatedAt: time.Now().Add(-1 * 29 * 24 * time.Hour),
+			expectPriority: 1,
+		},
+		{
+			comments: []github.IssueComment{
+				flakecomment(1, time.Now()),
+				flakecomment(1, time.Now().Add(-1*3*24*time.Hour)),
+			},
+			issueCreatedAt: time.Now().Add(-1 * 6 * 24 * time.Hour),
+			expectPriority: 0,
+		},
+	}
+	for _, tc := range testcases {
+		p := autoPrioritize(tc.comments, &tc.issueCreatedAt)
+		if p.Priority() != tc.expectPriority {
+			t.Errorf("Expected priority: %d, But got: %d", tc.expectPriority, p.Priority())
+		}
+	}
+}