Skip to content
This repository was archived by the owner on Dec 1, 2018. It is now read-only.

Commit fcdea54

Browse files
authored
Merge pull request #1785 from AltSchool/feautre/gcl-on-aws
Allow GCL sink to authenticate with private key on AWS
2 parents 6c245e7 + 1afe771 commit fcdea54

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

events/sinks/gcl/gcl.go

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
gce_util "k8s.io/heapster/common/gce"
2424
"k8s.io/heapster/events/core"
2525

26-
gce "cloud.google.com/go/compute/metadata"
2726
"github.com/golang/glog"
2827
"golang.org/x/oauth2"
2928
"golang.org/x/oauth2/google"
@@ -80,21 +79,21 @@ func (sink *gclSink) Stop() {
8079
}
8180

8281
func CreateGCLSink(uri *url.URL) (core.EventSink, error) {
83-
if err := gce_util.EnsureOnGCE(); err != nil {
84-
return nil, err
85-
}
86-
87-
// Detect project ID
88-
projectId, err := gce.ProjectID()
82+
client, err := google.DefaultClient(oauth2.NoContext, gcl.LoggingWriteScope)
8983
if err != nil {
90-
return nil, err
84+
return nil, fmt.Errorf("error creating oauth2 client: %v", err)
9185
}
9286

9387
// Create Google Cloud Logging service.
94-
client := oauth2.NewClient(oauth2.NoContext, google.ComputeTokenSource(""))
9588
gclService, err := gcl.New(client)
9689
if err != nil {
97-
return nil, err
90+
return nil, fmt.Errorf("error creating GCL service: %v", err)
91+
}
92+
93+
// Detect project ID
94+
projectId, err := gce_util.GetProjectId()
95+
if err != nil {
96+
return nil, fmt.Errorf("error getting GCP project ID: %v", err)
9897
}
9998

10099
sink := &gclSink{project: projectId, gclService: gclService}

0 commit comments

Comments
 (0)