Skip to content

[Feature] SandboxWarmPool rollout on template updates #323

@janetkuo

Description

@janetkuo

Currently, the SandboxWarmPool controller does not trigger a rollout when its spec.sandboxTemplateRef is changed or when the underlying SandboxTemplate specification is mutated. This results in state drift where the pool serves stale pods to new SandboxClaims.

While we don't necessarily need rollouts for Sandbox or SandboxClaim resources (because they handle active, singleton workloads), a SandboxWarmPool becomes ineffective if it cannot guarantee that provisioned resources match the most recent template configuration (because it handles idle, unclaimed resources).

As mentioned in the original design #34 (comment), we only need to do a recreate (kill all old ones and create new ones) instead of a rolling update.

#162 proposes to have warmpool create sandboxes instead of pods, so might affect the design of this feature.

/kind feature

Metadata

Metadata

Labels

help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions