Merge pull request #1395 from AlbeeSo/feat/auto-coredump

set ossfs process dumpable

Author: k8s-ci-robot

pkg/mounter/oss/ossfs.go

@@ -221,6 +221,10 @@ func (f *fuseOssfs) buildPodSpec(c *mounterutils.FusePodContext, target string)
 
 	container.Args = []string{"--socket=" + socketPath, "-v=4"}
 
+	if strings.ToLower(f.config.Extra["set-dumpable"]) == "true" {
+		container.Env = append(container.Env, corev1.EnvVar{Name: "SET_DUMPABLE", Value: "true"})
+	}
+
 	spec.Containers = []corev1.Container{container}
 	spec.NodeName = c.NodeName
 	spec.HostNetwork = true

pkg/mounter/oss/ossfs2.go

@@ -246,6 +246,10 @@ func (f *fuseOssfs2) buildPodSpec(c *mounterutils.FusePodContext, target string)
 
 	container.Args = []string{"--socket=" + socketPath, "-v=4"}
 
+	if strings.ToLower(f.config.Extra["set-dumpable"]) == "true" {
+		container.Env = append(container.Env, corev1.EnvVar{Name: "SET_DUMPABLE", Value: "true"})
+	}
+
 	spec.Containers = []corev1.Container{container}
 	spec.NodeName = c.NodeName
 	spec.HostNetwork = true

pkg/mounter/proxy/server/ossfs/driver.go

@@ -12,6 +12,8 @@ import (
 	"syscall"
 	"time"
 
+	"golang.org/x/sys/unix"
+
 	"github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/mounter/proxy"
 	"github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/mounter/proxy/server"
 	serverutils "github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/mounter/proxy/server"
@@ -79,6 +81,13 @@ func (h *Driver) Mount(ctx context.Context, req *proxy.MountRequest) error {
 	pid := cmd.Process.Pid
 	klog.InfoS("Started ossfs", "pid", pid, "args", args)
 
+	if dumpable := os.Getenv("SET_DUMPABLE"); dumpable == "true" {
+		err = unix.Prctl(unix.PR_SET_DUMPABLE, 1, 0, 0, 0)
+		if err != nil {
+			klog.ErrorS(err, "Failed to set process as dumpable")
+		}
+	}
+
 	ossfsExited := make(chan error, 1)
 	h.wg.Add(1)
 	h.pids.Store(pid, cmd)

pkg/mounter/proxy/server/ossfs2/driver.go

@@ -12,6 +12,8 @@ import (
 	"syscall"
 	"time"
 
+	"golang.org/x/sys/unix"
+
 	"github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/mounter/proxy"
 	"github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/mounter/proxy/server"
 	serverutils "github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/mounter/proxy/server"
@@ -85,6 +87,13 @@ func (h *Driver) Mount(ctx context.Context, req *proxy.MountRequest) error {
 	pid := cmd.Process.Pid
 	klog.InfoS("Started ossfs2", "pid", pid, "args", args)
 
+	if dumpable := os.Getenv("SET_DUMPABLE"); dumpable == "true" {
+		err = unix.Prctl(unix.PR_SET_DUMPABLE, 1, 0, 0, 0)
+		if err != nil {
+			klog.ErrorS(err, "Failed to set process as dumpable")
+		}
+	}
+
 	ossfsExited := make(chan error, 1)
 	h.wg.Add(1)
 	h.pids.Store(pid, cmd)

pkg/mounter/utils/fuse_pod_manager.go

@@ -174,6 +174,9 @@ func ExtractFuseContainerConfig(configmap *corev1.ConfigMap, name string) (confi
 				invalid = true
 			}
 		default:
+			// Initialize Extra map if nil. Currently supported keys in Extra:
+			// - "set-dumpable": enables dumpable flag for process of ossfs 1.0 / ossfs 2.0
+			// - "mime-support": enables MIME type support for ossfs 1.0
 			if config.Extra == nil {
 				config.Extra = make(map[string]string)
 			}