addressing comments

Author: Chao Xu

cmd/agent/main.go

@@ -102,7 +102,7 @@ func (o *GrpcProxyAgentOptions) Print() {
 	klog.Warningf("ProxyServerHost set to \"%s\".\n", o.proxyServerHost)
 	klog.Warningf("ProxyServerPort set to %d.\n", o.proxyServerPort)
 	klog.Warningf("AgentID set to %s.\n", o.agentID)
-	klog.Warningf("SyncInterval set to %d.\n", o.syncInterval)
+	klog.Warningf("SyncInterval set to %d seconds.\n", o.syncInterval)
 	klog.Warningf("ProbeInterval set to %d.\n", o.probeInterval)
 	klog.Warningf("ReconnectInterval set to %d.\n", o.reconnectInterval)
 }

pkg/agent/agentclient/client.go

@@ -55,6 +55,10 @@ func newAgentClientWithRedialableAgentClient(rac *RedialableAgentClient) *AgentC
 
 // Close closes the underlying stream.
 func (c *AgentClient) Close() {
+	if c.stream == nil {
+		klog.Warning("Unexpected empty AgentClient.stream")
+		return
+	}
 	c.stream.Close()
 }
 

pkg/agent/agentclient/clientset.go

@@ -1,5 +1,5 @@
 /*
-Copyright 2019 The Kubernetes Authors.
+Copyright 2020 The Kubernetes Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -29,7 +29,7 @@ import (
 
 // ClientSet consists of clients connected to each instance of an HA proxy server.
 type ClientSet struct {
-	mu      sync.Mutex              //protects the following
+	mu      sync.Mutex              //protects the clients.
 	clients map[string]*AgentClient // map between serverID and the client
 	// connects to this server.
 

pkg/agent/agentclient/stream.go

@@ -365,5 +365,8 @@ func (c *RedialableAgentClient) tryConnect() (connectResult, error) {
 }
 
 func (c *RedialableAgentClient) Close() {
+	if c.conn == nil {
+		klog.Warning("Unexpected empty RedialableAgentClient.stream")
+	}
 	c.conn.Close()
 }