Skip to content

Commit 3494341

Browse files
committed
Address comments
1 parent 2fa9dd1 commit 3494341

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pkg/agent/client.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ func (a *Client) Serve() {
356356
} else {
357357
select {
358358
case <-a.stopCh:
359-
klog.V(5).InfoS("could not read stream because agent client is shutting down", "err", err)
359+
klog.V(5).InfoS("could not read stream because agent client is shutting down", "serverID", a.serverID, "agentID", a.agentID, "err", err)
360360
default:
361361
// If stopCh is not closed, this is a legitimate, unexpected error.
362362
klog.ErrorS(err, "could not read stream", "serverID", a.serverID, "agentID", a.agentID)
@@ -414,11 +414,11 @@ func (a *Client) Serve() {
414414
}
415415
if err := a.Send(closePkt); err != nil {
416416
if err == io.EOF {
417-
klog.V(2).InfoS("received EOF; connection already closed", "connectionID", connID, "err", err)
417+
klog.V(2).InfoS("received EOF; connection already closed", "connectionID", connID, "dialID", dialReq.Random, "err", err)
418418
} else if _, ok := a.connManager.Get(connID); !ok {
419-
klog.V(5).InfoS("connection already closed", "connectionID", connID, "err", err)
419+
klog.V(5).InfoS("connection already closed", "connectionID", connID, "dialID", dialReq.Random, "err", err)
420420
} else {
421-
klog.ErrorS(err, "close response failure", "")
421+
klog.ErrorS(err, "close response failure", "connectionID", connID, "dialID", dialReq.Random)
422422
}
423423
}
424424
close(dataCh)

0 commit comments

Comments
 (0)