Skip to content

Commit 52cccb5

Browse files
authored
Merge pull request #607 from jkh52/fix-kind
Fix 'kind' example manifests.
2 parents 457af6a + 8ca5301 commit 52cccb5

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

.github/workflows/e2e.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,11 @@ jobs:
3636
mkdir _output
3737
3838
make docker-build/proxy-agent-amd64 REGISTRY=gcr.io/k8s-staging-kas-network-proxy TAG=local BASEIMAGE=${{ env.BASEIMAGE }}
39-
docker save gcr.io/k8s-staging-kas-network-proxy/proxy-agent-amd64:local > _output/konnectivity-agent.tar
39+
docker tag gcr.io/k8s-staging-kas-network-proxy/proxy-agent-amd64:local gcr.io/k8s-staging-kas-network-proxy/proxy-agent:master
40+
docker save gcr.io/k8s-staging-kas-network-proxy/proxy-agent:master > _output/konnectivity-agent.tar
4041
make docker-build/proxy-server-amd64 REGISTRY=gcr.io/k8s-staging-kas-network-proxy TAG=local BASEIMAGE=${{ env.BASEIMAGE }}
41-
docker save gcr.io/k8s-staging-kas-network-proxy/proxy-server-amd64:local > _output/konnectivity-server.tar
42+
docker tag gcr.io/k8s-staging-kas-network-proxy/proxy-server-amd64:local gcr.io/k8s-staging-kas-network-proxy/proxy-server:master
43+
docker save gcr.io/k8s-staging-kas-network-proxy/proxy-server:master > _output/konnectivity-server.tar
4244
4345
- uses: actions/upload-artifact@v4
4446
with:
@@ -153,8 +155,8 @@ jobs:
153155
# preload konnectivity images
154156
docker load --input konnectivity-server.tar
155157
docker load --input konnectivity-agent.tar
156-
/usr/local/bin/kind load docker-image gcr.io/k8s-staging-kas-network-proxy/proxy-server-amd64:local --name ${{ env.KIND_CLUSTER_NAME}}
157-
/usr/local/bin/kind load docker-image gcr.io/k8s-staging-kas-network-proxy/proxy-agent-amd64:local --name ${{ env.KIND_CLUSTER_NAME}}
158+
/usr/local/bin/kind load docker-image gcr.io/k8s-staging-kas-network-proxy/proxy-server:master --name ${{ env.KIND_CLUSTER_NAME}}
159+
/usr/local/bin/kind load docker-image gcr.io/k8s-staging-kas-network-proxy/proxy-agent:master --name ${{ env.KIND_CLUSTER_NAME}}
158160
kubectl apply -f examples/kind/konnectivity-server.yaml
159161
kubectl apply -f examples/kind/konnectivity-agent-ds.yaml
160162

examples/kind/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ $ kubectl apply -f konnectivity-agent-ds.yaml
3535
serviceaccount/konnectivity-agent created
3636
```
3737

38-
To validate that it works, run a custom image and try to exec into the pod (it goes through the konnectivity proxy):
38+
To validate that it works, run a custom image and get pod logs (it goes through the konnectivity proxy):
3939
```sh
4040
$ kubectl run test --image httpd:2
4141
pod/test created
@@ -45,7 +45,7 @@ test 0/1 ContainerCreating 0 4s
4545
$ kubectl get pods
4646
NAME READY STATUS RESTARTS AGE
4747
test 1/1 Running 0 6s
48-
$ kubectl exec -it test bash
49-
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl exec [POD] -- [COMMAND] instead.
48+
$ kubectl logs test
49+
...
50+
[Tue Apr 09 20:58:36.756720 2024] [mpm_event:notice] [pid 1:tid 139788897408896] AH00489: Apache/2.4.59 (Unix) configured -- resuming normal operations
5051
```
51-

examples/kind/konnectivity-agent-ds.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ spec:
3636
dnsPolicy: ClusterFirstWithHostNet
3737
containers:
3838
- name: konnectivity-agent-container
39-
image: gcr.io/k8s-staging-kas-network-proxy/proxy-agent-amd64:local
40-
imagePullPolicy: Never
39+
image: gcr.io/k8s-staging-kas-network-proxy/proxy-agent:master
4140
resources:
4241
requests:
4342
cpu: 50m

examples/kind/konnectivity-server.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,17 +55,20 @@ spec:
5555
hostNetwork: true
5656
containers:
5757
- name: konnectivity-server-container
58-
image: gcr.io/k8s-staging-kas-network-proxy/proxy-server-amd64:local
59-
imagePullPolicy: Never
58+
image: gcr.io/k8s-staging-kas-network-proxy/proxy-server:master
6059
resources:
6160
requests:
6261
cpu: 1m
62+
securityContext:
63+
allowPrivilegeEscalation: false
64+
runAsUser: 0
6365
command: [ "/proxy-server"]
6466
args: [
6567
"--log-file=/var/log/konnectivity-server.log",
6668
"--logtostderr=true",
6769
"--log-file-max-size=0",
6870
"--uds-name=/etc/kubernetes/konnectivity-server/konnectivity-server.socket",
71+
"--delete-existing-uds-file",
6972
"--cluster-cert=/etc/kubernetes/pki/apiserver.crt",
7073
"--cluster-key=/etc/kubernetes/pki/apiserver.key",
7174
"--server-port=0",

0 commit comments

Comments
 (0)