Merge pull request #75 from Jefftree/patch-2

k8s-ci-robot · web-flow · commit 67e354888f35 · 2020-03-05T15:22:49.000-08:00
Fix warning message if agent disconnects
diff --git a/pkg/agent/agentserver/backend_manager.go b/pkg/agent/agentserver/backend_manager.go
@@ -128,7 +128,7 @@ func (s *DefaultBackendManager) RemoveBackend(agentID string, conn agent.AgentSe
 	for i, c := range backends {
 		if c.conn == conn {
 			s.backends[agentID] = append(s.backends[agentID][:i], s.backends[agentID][i+1:]...)
-			if i == 0 && len(s.backends) != 0 {
+			if i == 0 && len(s.backends[agentID]) != 0 {
 				klog.Warningf("this should not happen. Removed connection %v that is not the first connection, remaining connections are %v", conn, s.backends[agentID])
 			}
 			found = true

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ func (s *DefaultBackendManager) RemoveBackend(agentID string, conn agent.AgentSe`
`128`	`128`	`for i, c := range backends {`
`129`	`129`	`if c.conn == conn {`
`130`	`130`	`s.backends[agentID] = append(s.backends[agentID][:i], s.backends[agentID][i+1:]...)`
`131`		`- if i == 0 && len(s.backends) != 0 {`
	`131`	`+ if i == 0 && len(s.backends[agentID]) != 0 {`
`132`	`132`	`klog.Warningf("this should not happen. Removed connection %v that is not the first connection, remaining connections are %v", conn, s.backends[agentID])`
`133`	`133`	`}`
`134`	`134`	`found = true`