Review comments

Author: carreter

cmd/agent/app/options/options.go

@@ -85,8 +85,6 @@ type GrpcProxyAgentOptions struct {
 	// Providing a label selector enables updating the server count by counting the
 	// number of valid leases matching the selector.
 	ServerLeaseSelector string
-	// Lease informer resync period.
-	InformerResync time.Duration
 	// Path to kubeconfig (used by kubernetes client for lease listing)
 	KubeconfigPath string
 }
@@ -132,7 +130,6 @@ func (o *GrpcProxyAgentOptions) Flags() *pflag.FlagSet {
 	flags.BoolVar(&o.SyncForever, "sync-forever", o.SyncForever, "If true, the agent continues syncing, in order to support server count changes.")
 	flags.IntVar(&o.XfrChannelSize, "xfr-channel-size", 150, "Set the size of the channel for transferring data between the agent and the proxy server.")
 	flags.StringVar(&o.ServerLeaseSelector, "server-lease-selector", o.ServerLeaseSelector, "Providing a label selector enables updating the server count by counting the number of valid leases matching the selector.")
-	flags.DurationVar(&o.InformerResync, "informer-resync", o.InformerResync, "Lease informer resync period in seconds")
 	flags.StringVar(&o.KubeconfigPath, "kubeconfig", o.KubeconfigPath, "absolute path to the kubeconfig file")
 	return flags
 }
@@ -267,7 +264,6 @@ func NewGrpcProxyAgentOptions() *GrpcProxyAgentOptions {
 		SyncForever:               false,
 		XfrChannelSize:            150,
 		ServerLeaseSelector:       "",
-		InformerResync:            10 * time.Second,
 		KubeconfigPath:            "",
 	}
 	return &o

pkg/agent/lease_counter.go

@@ -54,8 +54,8 @@ func (lc *ServerLeaseCounter) Count(ctx context.Context) int {
 	if err != nil {
 		klog.Errorf("could not list leases to update server count, using fallback count (%v): %v", lc.fallbackCount, err)
 
-		apiStatus, ok := err.(apierrors.APIStatus)
-		if ok || errors.As(err, &apiStatus) {
+		var apiStatus apierrors.APIStatus
+		if errors.As(err, &apiStatus) {
 			status := apiStatus.Status()
 			metrics.Metrics.ObserveLeaseList(int(status.Code), string(status.Reason))
 		} else {
@@ -75,10 +75,6 @@ func (lc *ServerLeaseCounter) Count(ctx context.Context) int {
 		}
 	}
 
-	if count == 0 {
-		return lc.fallbackCount
-	}
-
 	if count != lc.fallbackCount {
 		lc.fallbackCount = count
 	}