Skip to content

Commit acfe94e

Browse files
authored
Merge pull request #39 from Sh4d1/fix_makefile
fix Makefile commands
2 parents 71f9d28 + 4a42495 commit acfe94e

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

Makefile

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ AGENT_FULL_IMAGE ?= $(REGISTRY)/$(AGENT_IMAGE_NAME)
2626

2727
TAG ?= $(shell git rev-parse HEAD)
2828

29+
DOCKER_CMD ?= docker
2930
DOCKER_CLI_EXPERIMENTAL ?= enabled
3031

3132
## --------------------------------------
@@ -139,7 +140,7 @@ docker-push: docker-push/proxy-agent docker-push/proxy-server
139140
docker-build/proxy-agent: cmd/agent/main.go proto/agent/agent.pb.go
140141
@[ "${TAG}" ] || ( echo "TAG is not set"; exit 1 )
141142
echo "Building proxy-agent for ${ARCH}"
142-
docker build . --build-arg ARCH=$(ARCH) -f artifacts/images/agent-build.Dockerfile -t ${AGENT_FULL_IMAGE}-$(ARCH):${TAG}
143+
${DOCKER_CMD} build . --build-arg ARCH=$(ARCH) -f artifacts/images/agent-build.Dockerfile -t ${AGENT_FULL_IMAGE}-$(ARCH):${TAG}
143144

144145
.PHONY: docker-push/proxy-agent
145146
docker-push/proxy-agent: docker-build/proxy-agent
@@ -150,7 +151,7 @@ docker-push/proxy-agent: docker-build/proxy-agent
150151
docker-build/proxy-server: cmd/proxy/main.go proto/agent/agent.pb.go proto/proxy.pb.go
151152
@[ "${TAG}" ] || ( echo "TAG is not set"; exit 1 )
152153
echo "Building proxy-server for ${ARCH}"
153-
docker build . --build-arg ARCH=$(ARCH) -f artifacts/images/server-build.Dockerfile -t ${SERVER_FULL_IMAGE}-$(ARCH):${TAG}
154+
${DOCKER_CMD} build . --build-arg ARCH=$(ARCH) -f artifacts/images/server-build.Dockerfile -t ${SERVER_FULL_IMAGE}-$(ARCH):${TAG}
154155

155156
.PHONY: docker-push/proxy-server
156157
docker-push/proxy-server: docker-build/proxy-server
@@ -185,15 +186,15 @@ docker-push/proxy-server-%:
185186
docker-push-manifest/proxy-agent: ## Push the fat manifest docker image.
186187
## Minimum docker version 18.06.0 is required for creating and pushing manifest images.
187188
docker manifest create --amend $(AGENT_FULL_IMAGE):$(TAG) $(shell echo $(ALL_ARCH) | sed -e "s~[^ ]*~$(AGENT_FULL_IMAGE)\-&:$(TAG)~g")
188-
@for arch in $(ALL_ARCH); do docker manifest annotate --arch $${arch} ${AGENT_FULL_IMAGE}:${TAG} ${AGENT_FULL_IMAGE}-$${arch}:${TAG}; done
189-
docker manifest push --purge $(AGENT_FULL_IMAGE):$(TAG)
189+
@for arch in $(ALL_ARCH); do ${DOCKER_CMD} manifest annotate --arch $${arch} ${AGENT_FULL_IMAGE}:${TAG} ${AGENT_FULL_IMAGE}-$${arch}:${TAG}; done
190+
${DOCKER_CMD} manifest push --purge $(AGENT_FULL_IMAGE):$(TAG)
190191

191192
.PHONY: docker-push-manifest/proxy-server
192193
docker-push-manifest/proxy-server: ## Push the fat manifest docker image.
193194
## Minimum docker version 18.06.0 is required for creating and pushing manifest images.
194-
docker manifest create --amend $(SERVER_FULL_IMAGE):$(TAG) $(shell echo $(ALL_ARCH) | sed -e "s~[^ ]*~$(SERVER_FULL_IMAGE)\-&:$(TAG)~g")
195-
@for arch in $(ALL_ARCH); do docker manifest annotate --arch $${arch} ${SERVER_FULL_IMAGE}:${TAG} ${SERVER_FULL_IMAGE}-$${arch}:${TAG}; done
196-
docker manifest push --purge $(SERVER_FULL_IMAGE):$(TAG)
195+
${DOCKER_CMD} manifest create --amend $(SERVER_FULL_IMAGE):$(TAG) $(shell echo $(ALL_ARCH) | sed -e "s~[^ ]*~$(SERVER_FULL_IMAGE)\-&:$(TAG)~g")
196+
@for arch in $(ALL_ARCH); do ${DOCKER_CMD} manifest annotate --arch $${arch} ${SERVER_FULL_IMAGE}:${TAG} ${SERVER_FULL_IMAGE}-$${arch}:${TAG}; done
197+
${DOCKER_CMD} manifest push --purge $(SERVER_FULL_IMAGE):$(TAG)
197198

198199
## --------------------------------------
199200
## Release

0 commit comments

Comments
 (0)