Skip to content

Commit b8db36e

Browse files
authored
Merge pull request #50 from dberkov/uds-name
Align proxy/main.go's flags naming convention with rest of the project
2 parents b03c198 + 2359a07 commit b8db36e

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cmd/proxy/main.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,11 @@ func (o *ProxyRunOptions) Flags() *pflag.FlagSet {
8989
flags.StringVar(&o.clusterCert, "cluster-cert", o.clusterCert, "If non-empty secure communication with this cert.")
9090
flags.StringVar(&o.clusterKey, "cluster-key", o.clusterKey, "If non-empty secure communication with this key.")
9191
flags.StringVar(&o.clusterCaCert, "cluster-ca-cert", o.clusterCaCert, "If non-empty the CA we use to validate Agent clients.")
92-
flags.StringVar(&o.mode, "mode", "grpc", "Mode can be either 'grpc' or 'http-connect'.")
93-
flags.StringVar(&o.udsName, "udsName", "", "UdsName should be empty for TCP traffic. For UDS set to its name.")
94-
flags.UintVar(&o.serverPort, "server-port", 8090, "Port we listen for server connections on. Set to 0 for UDS.")
95-
flags.UintVar(&o.agentPort, "agent-port", 8091, "Port we listen for agent connections on.")
96-
flags.UintVar(&o.adminPort, "admin-port", 8092, "Port we listen for admin connections on.")
92+
flags.StringVar(&o.mode, "mode", o.mode, "Mode can be either 'grpc' or 'http-connect'.")
93+
flags.StringVar(&o.udsName, "uds-name", o.udsName, "uds-name should be empty for TCP traffic. For UDS set to its name.")
94+
flags.UintVar(&o.serverPort, "server-port", o.serverPort, "Port we listen for server connections on. Set to 0 for UDS.")
95+
flags.UintVar(&o.agentPort, "agent-port", o.agentPort, "Port we listen for agent connections on.")
96+
flags.UintVar(&o.adminPort, "admin-port", o.adminPort, "Port we listen for admin connections on.")
9797
return flags
9898
}
9999

examples/kubernetes/konnectivity-server.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ spec:
1919
"--log-file=/var/log/konnectivity-server.log",
2020
"--logtostderr=false",
2121
"--log-file-max-size=0",
22-
"--udsName=/etc/srv/kubernetes/konnectivity/konnectivity-server.socket",
22+
"--uds-name=/etc/srv/kubernetes/konnectivity/konnectivity-server.socket",
2323
"--cluster-cert=/etc/srv/kubernetes/pki/apiserver.crt",
2424
"--cluster-key=/etc/srv/kubernetes/pki/apiserver.key",
2525
"--server-port=0",

0 commit comments

Comments
 (0)