Skip to content

Commit bfea27c

Browse files
committed
Make kind-e2e run on different k8s versions
1 parent 801565d commit bfea27c

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

.github/workflows/e2e.yaml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,15 @@ jobs:
5252
name: kind-e2e
5353
runs-on: ubuntu-20.04
5454
timeout-minutes: 100
55+
needs:
56+
- build
57+
env:
58+
REGISTRY: gcr.io/k8s-staging-kas-network-proxy
59+
KIND_IMAGE: kindest/node${{ matrix.k8s }}
60+
strategy:
61+
fail-fast: false
62+
matrix:
63+
k8s: [ v1.27.11, v1.28.7, v1.29.2 ]
5564
steps:
5665
- name: Check out code
5766
uses: actions/checkout@v4
@@ -66,7 +75,7 @@ jobs:
6675
chmod +x ./kind
6776
sudo mv ./kind /usr/local/bin/kind
6877
- name: Run e2e tests
69-
run: REGISTRY=github-workflow make test-e2e
78+
run: make test-e2e
7079
e2e:
7180
name: e2e
7281
runs-on: ubuntu-20.04

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ TAG ?= $(shell git rev-parse HEAD)
5454
DOCKER_CMD ?= docker
5555
DOCKER_CLI_EXPERIMENTAL ?= enabled
5656
PROXY_SERVER_IP ?= 127.0.0.1
57+
58+
KIND_IMAGE ?= kindest/node
5759
## --------------------------------------
5860
## Testing
5961
## --------------------------------------
@@ -82,7 +84,7 @@ test-integration: build
8284

8385
.PHONY: test-e2e
8486
test-e2e: docker-build
85-
go test -mod=vendor ./e2e -race -agent-image ${AGENT_FULL_IMAGE}-$(TARGETARCH):${TAG} -server-image ${SERVER_FULL_IMAGE}-$(TARGETARCH):${TAG}
87+
go test -mod=vendor ./e2e -race -agent-image ${AGENT_FULL_IMAGE}-$(TARGETARCH):${TAG} -server-image ${SERVER_FULL_IMAGE}-$(TARGETARCH):${TAG} -kind-image ${KIND_IMAGE}
8688

8789
## --------------------------------------
8890
## Binaries

e2e/main_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ var (
2424
testenv env.Environment
2525
agentImage = flag.String("agent-image", "", "The proxy agent's docker image.")
2626
serverImage = flag.String("server-image", "", "The proxy server's docker image.")
27+
kindImage = flag.String("kind-image", "kindest/node", "Image to use for kind nodes.")
2728
)
2829

2930
func TestMain(m *testing.M) {
@@ -39,7 +40,7 @@ func TestMain(m *testing.M) {
3940

4041
testenv = env.New()
4142
kindClusterName := "kind-test"
42-
kindCluster := kind.NewCluster(kindClusterName)
43+
kindCluster := kind.NewCluster(kindClusterName).WithOpts(kind.WithImage(*kindImage))
4344

4445
testenv.Setup(
4546
envfuncs.CreateCluster(kindCluster, kindClusterName),

0 commit comments

Comments
 (0)