Revert "Merge pull request #685 from makhov/respect-log-level-from-args" #781
+6
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-level-from-args" This reverts commit 4ce5f06. This commit reverts a previous modification to the flag handling logic in the agent and server's main() functions. A prior change introduced a condition (`if local.Lookup("v") == nil`) before setting the default klog verbosity level. This condition was incorrect because `klog.InitFlags()` always defines the `-v` flag, meaning the default verbosity was never being applied. This caused the effective log level to fall back to klog's default of `0` instead of the intended `4`. This change restores the original, correct behavior by unconditionally setting the verbosity to `4`. This ensures logs are visible by default while still allowing the user to override the setting via the command line.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Contributor
Author
Contributor
|
#785 fixes the order |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, ipochi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4ce5f06.
This commit reverts a previous modification to the flag handling logic in the agent and server's main() functions.
A prior change introduced a condition (
if local.Lookup("v") == nil) before setting the default klog verbosity level. This condition was incorrect becauseklog.InitFlags()always defines the-vflag, meaning the default verbosity was never being applied. This caused the effective log level to fall back to klog's default of0instead of the intended4.This change restores the original, correct behavior by unconditionally setting the verbosity to
4. This ensures logs are visible by default while still allowing the user to override the setting via the command line.#685 (comment)
Fixes: #780