Skip to content

Commit 8eb8b1a

Browse files
authored
Merge pull request #1195 from rimaulana/master
Added Fargate support in the EFS CSI Controller
2 parents 737f323 + b002dd3 commit 8eb8b1a

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

pkg/cloud/k8s_metadata.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ func (k kubernetesApiMetadataProvider) getMetadata() (MetadataService, error) {
4444
return nil, fmt.Errorf("node providerID empty, cannot parse")
4545
}
4646

47-
re := regexp.MustCompile("i-[a-z0-9]+$")
47+
re := regexp.MustCompile("i-[a-z0-9]+$|[a-z0-9]{32}")
4848
instanceID := re.FindString(providerId)
4949
if instanceID == "" {
5050
return nil, fmt.Errorf("did not find aws instance ID in node providerID string")

pkg/cloud/k8s_metadata_test.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,20 @@ func TestInstanceIdParsedFromProviderIdCorrectly(t *testing.T) {
7878
}
7979
}
8080

81+
func TestTaskIdParsedFromProviderIdCorrectly(t *testing.T) {
82+
clientSet := setupKubernetesClient(t, nodeName, createFargateNode())
83+
k8sMp := kubernetesApiMetadataProvider{api: clientSet}
84+
85+
metadata, err := k8sMp.getMetadata()
86+
87+
if err != nil {
88+
t.Fatalf("Error occurred when parsing instance ID, %v", err)
89+
}
90+
if metadata.GetInstanceID() != taskId {
91+
t.Fatalf("Instance ID not extracted correctly, expected %s, got %s", taskId, metadata.GetInstanceID())
92+
}
93+
}
94+
8195
func TestRegionAndZoneExtractedCorrectlyFromLabels(t *testing.T) {
8296
clientSet := setupKubernetesClient(t, nodeName, createDefaultNode())
8397
k8sMp := kubernetesApiMetadataProvider{api: clientSet}
@@ -123,3 +137,7 @@ func createNode(nodeName string, nodeRegion string, nodeZone string, providerId
123137
func createDefaultNode() *v1.Node {
124138
return createNode(nodeName, nodeRegion, nodeZone, fmt.Sprintf("aws:///%s/%s", nodeZone, instanceId))
125139
}
140+
141+
func createFargateNode() *v1.Node {
142+
return createNode(nodeName, nodeRegion, nodeZone, fmt.Sprintf("aws:///%s/1234567890-%s/%s", nodeZone, taskId, nodeName))
143+
}

0 commit comments

Comments
 (0)