Refactor command line flags to Options type#1741
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Feb 3, 2026
Merged
Refactor command line flags to Options type#1741k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
Let's refactor command line flags to its own type so that we can just pass Options to driver when constructing a new driver.
c76142b to
e958741
Compare
Contributor
Author
|
/retest-required |
samuhale
approved these changes
Feb 3, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidXU12345, samuhale The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's refactor command line flags to its own type so that we can just pass Options to driver when constructing a new driver.
Is this a bug fix or adding new feature?
N/A
What is this PR about? / Why do we need it?
As we are adding more and more options in the CLI, let's package all options in its own type with validation.
What testing is done?
volume-attach-limit-opt-in=trueandvolume-attach-limit=0max-inflight-mount-calls-opt-in=trueandmax-inflight-mount-calls=0