Skip to content

Commit 3683793

Browse files
authored
Merge pull request #29 from hughdanliu/helm-labels
Adopt Kubernetes recommended labels
2 parents cb8dfb0 + ca2f5e2 commit 3683793

File tree

12 files changed

+33
-31
lines changed

12 files changed

+33
-31
lines changed

charts/aws-fsx-openzfs-csi-driver/templates/_helpers.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ app.kubernetes.io/managed-by: {{ .Release.Service }}
4949
Common selector labels
5050
*/}}
5151
{{- define "aws-fsx-openzfs-csi-driver.selectorLabels" -}}
52-
app.kubernetes.io/name: {{ include "aws-fsx-openzfs-csi-driver.name" . }}
52+
app.kubernetes.io/part-of: {{ include "aws-fsx-openzfs-csi-driver.name" . }}
5353
{{- if ne .Release.Name "kustomize" }}
5454
app.kubernetes.io/instance: {{ .Release.Name }}
5555
{{- end }}

charts/aws-fsx-openzfs-csi-driver/templates/controller-deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ spec:
1212
{{- end }}
1313
selector:
1414
matchLabels:
15-
app: fsx-openzfs-csi-controller
15+
app.kubernetes.io/name: fsx-openzfs-csi-controller
1616
{{- include "aws-fsx-openzfs-csi-driver.selectorLabels" . | nindent 6 }}
1717
template:
1818
metadata:
1919
labels:
20-
app: fsx-openzfs-csi-controller
20+
app.kubernetes.io/name: fsx-openzfs-csi-controller
2121
{{- include "aws-fsx-openzfs-csi-driver.labels" . | nindent 8 }}
2222
{{- if .Values.controller.podLabels }}
2323
{{- toYaml .Values.controller.podLabels | nindent 8 }}

charts/aws-fsx-openzfs-csi-driver/templates/node-daemonset.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,19 @@ metadata:
55
name: fsx-openzfs-csi-node
66
namespace: {{ .Release.Namespace }}
77
labels:
8+
app.kubernetes.io/name: fsx-openzfs-csi-node
89
{{- include "aws-fsx-openzfs-csi-driver.labels" . | nindent 4 }}
910
spec:
1011
selector:
1112
matchLabels:
12-
app: fsx-openzfs-csi-node
13+
app.kubernetes.io/name: fsx-openzfs-csi-node
1314
{{- include "aws-fsx-openzfs-csi-driver.selectorLabels" . | nindent 6 }}
1415
updateStrategy:
1516
{{- toYaml .Values.node.updateStrategy | nindent 4 }}
1617
template:
1718
metadata:
1819
labels:
19-
app: fsx-openzfs-csi-node
20+
app.kubernetes.io/name: fsx-openzfs-csi-node
2021
{{- include "aws-fsx-openzfs-csi-driver.labels" . | nindent 8 }}
2122
{{- if .Values.node.podLabels }}
2223
{{- toYaml .Values.node.podLabels | nindent 8 }}

charts/aws-fsx-openzfs-csi-driver/templates/poddisruptionbudget-controller.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ metadata:
1212
spec:
1313
selector:
1414
matchLabels:
15-
app: fsx-openzfs-csi-controller
15+
app.kubernetes.io/name: fsx-openzfs-csi-controller
1616
{{- include "aws-fsx-openzfs-csi-driver.selectorLabels" . | nindent 6 }}
1717
{{- if le (.Values.controller.replicaCount | int) 2 }}
1818
maxUnavailable: 1

charts/aws-fsx-openzfs-csi-driver/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ controller:
102102
- podAffinityTerm:
103103
labelSelector:
104104
matchExpressions:
105-
- key: app
105+
- key: app.kubernetes.io/name
106106
operator: In
107107
values:
108108
- fsx-openzfs-csi-controller

deploy/kubernetes/base/controller-deployment.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ apiVersion: apps/v1
55
metadata:
66
name: fsx-openzfs-csi-controller
77
labels:
8-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
8+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
99
spec:
1010
replicas: 2
1111
strategy:
@@ -14,13 +14,13 @@ spec:
1414
type: RollingUpdate
1515
selector:
1616
matchLabels:
17-
app: fsx-openzfs-csi-controller
18-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
17+
app.kubernetes.io/name: fsx-openzfs-csi-controller
18+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
1919
template:
2020
metadata:
2121
labels:
22-
app: fsx-openzfs-csi-controller
23-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
22+
app.kubernetes.io/name: fsx-openzfs-csi-controller
23+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
2424
spec:
2525
nodeSelector:
2626
kubernetes.io/os: linux
@@ -41,7 +41,7 @@ spec:
4141
- podAffinityTerm:
4242
labelSelector:
4343
matchExpressions:
44-
- key: app
44+
- key: app.kubernetes.io/name
4545
operator: In
4646
values:
4747
- fsx-openzfs-csi-controller

deploy/kubernetes/base/controller-serviceaccount.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ kind: ServiceAccount
55
metadata:
66
name: fsx-openzfs-csi-controller-sa
77
labels:
8-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
8+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
99
---
1010
# Source: aws-fsx-openzfs-csi-driver/templates/controller-serviceaccount.yaml
1111
kind: ClusterRole
1212
apiVersion: rbac.authorization.k8s.io/v1
1313
metadata:
1414
name: fsx-openzfs-csi-external-provisioner-role
1515
labels:
16-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
16+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
1717
rules:
1818
# The following rule should be uncommented for plugins that require secrets
1919
# for provisioning.
@@ -54,7 +54,7 @@ apiVersion: rbac.authorization.k8s.io/v1
5454
metadata:
5555
name: fsx-openzfs-csi-external-resizer-role
5656
labels:
57-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
57+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
5858
rules:
5959
# The following rule should be uncommented for plugins that require secrets
6060
# for provisioning.
@@ -86,7 +86,7 @@ apiVersion: rbac.authorization.k8s.io/v1
8686
metadata:
8787
name: fsx-openzfs-csi-external-snapshotter-role
8888
labels:
89-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
89+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
9090
rules:
9191
- apiGroups: [ "" ]
9292
resources: [ "events" ]
@@ -112,7 +112,7 @@ apiVersion: rbac.authorization.k8s.io/v1
112112
metadata:
113113
name: fsx-openzfs-csi-external-provisioner-binding
114114
labels:
115-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
115+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
116116
subjects:
117117
- kind: ServiceAccount
118118
name: fsx-openzfs-csi-controller-sa
@@ -127,7 +127,7 @@ apiVersion: rbac.authorization.k8s.io/v1
127127
metadata:
128128
name: fsx-openzfs-csi-external-resizer-binding
129129
labels:
130-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
130+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
131131
subjects:
132132
- kind: ServiceAccount
133133
name: fsx-openzfs-csi-controller-sa
@@ -142,7 +142,7 @@ apiVersion: rbac.authorization.k8s.io/v1
142142
metadata:
143143
name: fsx-openzfs-csi-external-snapshotter-binding
144144
labels:
145-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
145+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
146146
subjects:
147147
- kind: ServiceAccount
148148
name: fsx-openzfs-csi-controller-sa

deploy/kubernetes/base/csidriver.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ kind: CSIDriver
55
metadata:
66
name: fsx.openzfs.csi.aws.com
77
labels:
8-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
8+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
99
spec:
1010
attachRequired: false
1111
podInfoOnMount: false

deploy/kubernetes/base/node-daemonset.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,22 @@ apiVersion: apps/v1
66
metadata:
77
name: fsx-openzfs-csi-node
88
labels:
9-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
9+
app.kubernetes.io/name: fsx-openzfs-csi-node
10+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
1011
spec:
1112
selector:
1213
matchLabels:
13-
app: fsx-openzfs-csi-node
14-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
14+
app.kubernetes.io/name: fsx-openzfs-csi-node
15+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
1516
updateStrategy:
1617
rollingUpdate:
1718
maxUnavailable: 10%
1819
type: RollingUpdate
1920
template:
2021
metadata:
2122
labels:
22-
app: fsx-openzfs-csi-node
23-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
23+
app.kubernetes.io/name: fsx-openzfs-csi-node
24+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver
2425
spec:
2526
affinity:
2627
nodeAffinity:

deploy/kubernetes/base/node-serviceaccount.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ kind: ServiceAccount
55
metadata:
66
name: fsx-openzfs-csi-node-sa
77
labels:
8-
app.kubernetes.io/name: aws-fsx-openzfs-csi-driver
8+
app.kubernetes.io/part-of: aws-fsx-openzfs-csi-driver

0 commit comments

Comments
 (0)