fix: delete snapshot should not delete file share

andyzhangx · andyzhangx · commit 437e682a415f · 2025-05-13T03:52:10.000Z
diff --git a/pkg/azurefile/controllerserver.go b/pkg/azurefile/controllerserver.go
@@ -1074,7 +1074,9 @@ func (d *Driver) DeleteSnapshot(ctx context.Context, req *csi.DeleteSnapshotRequ
 		if err != nil {
 			return nil, status.Errorf(codes.Internal, "failed to get snapshot client for subID(%s): %v", subsID, err)
 		}
-		deleteErr = fileshareClient.Delete(ctx, rgName, accountName, fileShareName, nil)
+		deleteErr = fileshareClient.Delete(ctx, rgName, accountName, fileShareName, &armstorage.FileSharesClientDeleteOptions{
+			XMSSnapshot: to.Ptr(snapshot),
+		})
 	}
 
 	if deleteErr != nil {

Original file line number	Diff line number	Diff line change
`@@ -1074,7 +1074,9 @@ func (d Driver) DeleteSnapshot(ctx context.Context, req csi.DeleteSnapshotRequ`
`1074`	`1074`	`if err != nil {`
`1075`	`1075`	`return nil, status.Errorf(codes.Internal, "failed to get snapshot client for subID(%s): %v", subsID, err)`
`1076`	`1076`	`}`
`1077`		`- deleteErr = fileshareClient.Delete(ctx, rgName, accountName, fileShareName, nil)`
	`1077`	`+ deleteErr = fileshareClient.Delete(ctx, rgName, accountName, fileShareName, &armstorage.FileSharesClientDeleteOptions{`
	`1078`	`+ XMSSnapshot: to.Ptr(snapshot),`
	`1079`	`+ })`
`1078`	`1080`	`}`
`1079`	`1081`
`1080`	`1082`	`if deleteErr != nil {`