V0.4.0 Release

Author: dabradley

.github/ISSUE_TEMPLATE/support.md

@@ -4,7 +4,7 @@ about: Ask questions about this project
 
 ---
 
-<!-- 
+<!--
 STOP -- PLEASE READ!
 
 GitHub is not the right place for support requests.

.github/PULL_REQUEST_TEMPLATE.md

@@ -31,7 +31,7 @@ Optionally add one or more of the following kinds if applicable:
 **What this PR does / why we need it**:
 
 **Which issue(s) this PR fixes**:
-<!-- 
+<!--
 *Automatically closes linked issue when PR is merged.
 Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
 _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*

.github/workflows/long_haul.yaml

@@ -12,11 +12,11 @@ name: Long-Haul Test
 jobs:
   Run-long-haul-on-AKS:
     name: Run long-haul on AKS
-    runs-on: ubuntu-latest    
+    runs-on: ubuntu-latest
     steps:
       - name: Check out code
         uses: actions/checkout@v4
-        
+
       - name: Azure Login
         uses: Azure/login@v1.1
         with:

.github/workflows/static.yaml

@@ -18,6 +18,7 @@ jobs:
               with:
                 go-version-file: 'go.mod'
             - name: Run linter
-              uses: golangci/golangci-lint-action@v6
+              uses: golangci/golangci-lint-action@v9
               with:
                   working-directory: pkg
+                  version: v2.6

.github/workflows/trivy.yaml

@@ -34,7 +34,17 @@ jobs:
       - name: Run Trivy vulnerability scanner
         uses: aquasecurity/trivy-action@master
         with:
-          image-ref: 'test/azurelustre-csi:latest'
+          image-ref: 'test/azurelustre-csi:latest-jammy'
+          format: 'table'
+          exit-code: '1'
+          ignore-unfixed: true
+          vuln-type: 'os,library'
+          severity: 'CRITICAL,HIGH,MEDIUM,LOW,UNKNOWN'
+
+      - name: Run Trivy vulnerability scanner
+        uses: aquasecurity/trivy-action@master
+        with:
+          image-ref: 'test/azurelustre-csi:latest-noble'
           format: 'table'
           exit-code: '1'
           ignore-unfixed: true

.golangci.yaml

@@ -1,57 +1,100 @@
+version: "2"
 linters:
-  presets:
-    - bugs
   enable:
+    - asasalint
+    - asciicheck
+    - bidichk
+    - bodyclose
     - containedctx
+    - contextcheck
     - copyloopvar
     - decorder
     - dupl
+    - durationcheck
+    - errchkjson
+    - errorlint
+    - exhaustive
     - forbidigo
     - forcetypeassert
-    - gci
-    - gofmt
-    - gofumpt
-    - goimports
-    - gosimple
+    - gocheckcompilerdirectives
+    - gochecksumtype
+    - gosec
+    - gosmopolitan
     - grouper
     - inamedparam
-    - ineffassign
+    - loggercheck
+    - makezero
     - misspell
+    - musttag
+    - nilerr
+    - nilnesserr
+    - noctx
     - nolintlint
     - nonamedreturns
     - nosprintfhostport
     - predeclared
+    - protogetter
+    - reassign
+    - recvcheck
     - revive
-    - stylecheck
+    - rowserrcheck
+    - spancheck
+    - sqlclosecheck
+    - staticcheck
     - tagalign
-    - tenv
+    - testifylint
     - unconvert
-    - unused
     - usestdlibvars
     - wastedassign
     - whitespace
-linters-settings:
-  copyloopvar:
-    check-alias: true
-  errcheck:
-    check-blank: true
-    check-type-assertions: true
-    disable-default-exclusions: true
-  gofumpt:
-    extra-rules: true
-  grouper:
-    const-require-grouping: true
-    const-require-single-const: true
-    import-require-grouping: false
-    import-require-single-import: true
-    type-require-grouping: false
-    type-require-single-type: false
-    var-require-grouping: false
-    var-require-single-var: true
-  nolintlint:
-    require-explanation: true
-    require-specific: true
-  unparam:
-    check-exported: true
-run:
-  timeout: 30m
+    - zerologlint
+  settings:
+    copyloopvar:
+      check-alias: true
+    errcheck:
+      disable-default-exclusions: true
+      check-type-assertions: true
+      check-blank: true
+    grouper:
+      const-require-single-const: true
+      const-require-grouping: true
+      import-require-single-import: true
+      import-require-grouping: false
+      type-require-single-type: false
+      type-require-grouping: false
+      var-require-single-var: true
+      var-require-grouping: false
+    nolintlint:
+      require-explanation: true
+      require-specific: true
+    unparam:
+      check-exported: true
+  exclusions:
+    presets:
+      - comments
+      #- common-false-positives
+      #- legacy
+      #- std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+    rules:
+      - linters:
+          - revive
+        path: 'util/*'
+        text: 'var-naming: avoid meaningless package names'
+formatters:
+  enable:
+    - gci
+    - gofmt
+    - gofumpt
+    - goimports
+  settings:
+    gofumpt:
+      extra-rules: true
+  exclusions:
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Makefile

@@ -18,7 +18,7 @@ REGISTRY ?= azurelustre.azurecr.io
 REGISTRY_NAME ?= $(shell echo $(REGISTRY) | sed "s/.azurecr.io//g")
 TARGET ?= csi
 IMAGE_NAME ?= azurelustre-$(TARGET)
-IMAGE_VERSION ?= v0.3.1
+IMAGE_VERSION ?= v0.4.0
 CLOUD ?= AzurePublicCloud
 # Use a custom version for E2E tests if we are in Prow
 ifdef CI
@@ -39,9 +39,9 @@ GINKGO_FLAGS = -ginkgo.v
 GO111MODULE = on
 GOPATH ?= $(shell go env GOPATH)
 GOBIN ?= $(GOPATH)/bin
-CGO_ENABLED ?= 0
+CGO_ENABLED ?= 1
 DOCKER_CLI_EXPERIMENTAL = enabled
-export GOPATH GOBIN GO111MODULE DOCKER_CLI_EXPERIMENTAL
+export GOPATH GOBIN GO111MODULE DOCKER_CLI_EXPERIMENTAL CGO_ENABLED
 
 # The current context of image building
 # The architecture of the image
@@ -116,34 +116,27 @@ e2e-teardown:
 #
 .PHONY: quicklustre
 quicklustre:
-	CGO_ENABLED=0 GOOS=linux GOARCH=$(ARCH) go build -ldflags ${LDFLAGS} -mod vendor -o _output/azurelustreplugin ./pkg/azurelustreplugin
+	GOOS=linux GOARCH=$(ARCH) go build -ldflags ${LDFLAGS} -mod vendor -o _output/azurelustreplugin ./pkg/azurelustreplugin
 
 .PHONY: azurelustre
 azurelustre:
-	CGO_ENABLED=0 GOOS=linux GOARCH=$(ARCH) go build -a -ldflags ${LDFLAGS} -mod vendor -o _output/azurelustreplugin ./pkg/azurelustreplugin
+	GOOS=linux GOARCH=$(ARCH) go build -a -ldflags ${LDFLAGS} -mod vendor -o _output/azurelustreplugin ./pkg/azurelustreplugin
 
 .PHONY: azurelustre-dalec
 azurelustre-dalec:
 	GOOS=linux go build -a -ldflags ${LDFLAGS} -mod vendor -o /app/azurelustreplugin ./pkg/azurelustreplugin
 
-.PHONY: azurelustre-windows
-azurelustre-windows:
-	CGO_ENABLED=0 GOOS=windows go build -a -ldflags ${LDFLAGS} -mod vendor -o _output/azurelustreplugin.exe ./pkg/azurelustreplugin
-
-.PHONT: azurelustre-darwin
-azurelustre-darwin:
-	CGO_ENABLED=0 GOOS=darwin go build -a -ldflags ${LDFLAGS} -mod vendor -o _output/azurelustreplugin ./pkg/azurelustreplugin
-
 #
 # Azure Lustre: Docker build
 #
 .PHONY: quickcontainer
 quickcontainer: quicklustre
-	docker build -t $(IMAGE_TAG) --output=type=docker -f $(dockerfile) .
-
+	docker build -t $(IMAGE_TAG)-jammy --build-arg srcImage=ubuntu:22.04 --output=type=docker -f $(dockerfile) .
+	docker build -t $(IMAGE_TAG)-noble --build-arg srcImage=ubuntu:24.04 --output=type=docker -f $(dockerfile) .
 .PHONY: container
 container: $(build_lustre_source_code)
-	docker build -t $(IMAGE_TAG) --output=type=docker -f $(dockerfile) .
+	docker build -t $(IMAGE_TAG)-jammy --build-arg srcImage=ubuntu:22.04 --output=type=docker -f $(dockerfile) .
+	docker build -t $(IMAGE_TAG)-noble --build-arg srcImage=ubuntu:24.04 --output=type=docker -f $(dockerfile) .
 
 .PHONY: container-linux
 container-linux:
@@ -172,7 +165,8 @@ ifdef CI
 	docker manifest push --purge $(IMAGE_TAG)
 	docker manifest inspect $(IMAGE_TAG)
 else
-	docker push $(IMAGE_TAG)
+	docker push $(IMAGE_TAG)-jammy
+	docker push $(IMAGE_TAG)-noble
 endif
 
 .PHONY: push-latest
@@ -182,13 +176,23 @@ ifdef CI
 	docker manifest push --purge $(IMAGE_TAG_LATEST)
 	docker manifest inspect $(IMAGE_TAG_LATEST)
 else
-	docker push $(IMAGE_TAG_LATEST)
+	docker tag $(IMAGE_TAG)-jammy $(IMAGE_TAG_LATEST)-jammy
+	docker tag $(IMAGE_TAG)-noble $(IMAGE_TAG_LATEST)-noble
+	docker push $(IMAGE_TAG_LATEST)-jammy
+	docker push $(IMAGE_TAG_LATEST)-noble
 endif
 
 .PHONY: build-push
-build-push: $(build_lustre_source_code)
-	docker tag $(IMAGE_TAG) $(IMAGE_TAG_LATEST)
-	docker push $(IMAGE_TAG_LATEST)
+build-push: container push
+
+.PHONY: build-push-quick
+build-push-quick: quickcontainer push
+
+.PHONY: build-push-latest
+build-push-latest: container push-latest
+
+.PHONY: build-push-quick-latest
+build-push-quick-latest: quickcontainer push-latest
 
 #
 # IOR: docker build & publish

README.md

@@ -17,6 +17,7 @@ This driver allows Kubernetes to access Azure Lustre file system.
 | Driver version  | Image                                                           | Supported k8s version | Lustre client version |
 |-----------------|-----------------------------------------------------------------|-----------------------|-----------------------|
 | main branch     | mcr.microsoft.com/oss/kubernetes-csi/azurelustre-csi:latest     | 1.21+                 | 2.15.7                |
+| v0.4.0          | mcr.microsoft.com/oss/v2/kubernetes-csi/azurelustre-csi:v0.4.0  | 1.21+                 | 2.15.7                |
 | v0.3.1          | mcr.microsoft.com/oss/v2/kubernetes-csi/azurelustre-csi:v0.3.1  | 1.21+                 | 2.15.7                |
 | v0.3.0          | mcr.microsoft.com/oss/v2/kubernetes-csi/azurelustre-csi:v0.3.0  | 1.21+                 | 2.15.5                |
 | v0.2.0          | mcr.microsoft.com/oss/v2/kubernetes-csi/azurelustre-csi:v0.2.0  | 1.21+                 | 2.15.5                |

deploy/README-distribution-specific.md

@@ -0,0 +1,64 @@
+# Distribution-Specific Azure Lustre CSI Node Deployments
+
+## Overview
+
+This directory contains distribution-specific DaemonSet deployments for the Azure Lustre CSI driver. Each deployment targets a specific Ubuntu version to ensure proper Lustre client compatibility.
+
+## Files
+
+- `csi-azurelustre-node-jammy.yaml` - Ubuntu 22.04 (Jammy) nodes
+- `csi-azurelustre-node-noble.yaml` - Ubuntu 24.04 (Noble) nodes
+
+## Distribution Targeting
+
+Each deployment uses:
+
+1. **Node Targeting**: Uses node affinity and selectors to match correct node OS flavors
+2. **Container Image**: Version-specific image tags like `v0.4.0-jammy`, `v0.4.0-noble`
+3. **Unique Names**: Each DaemonSet has a unique name (`csi-azurelustre-node-jammy`) to prevent conflicts
+
+## Installation
+
+The `install-driver.sh` script deploys all necessary components:
+
+```bash
+./install-driver.sh
+```
+
+This will:
+
+- Deploy the controller (distribution-agnostic) and the OS-specific node DaemonSets
+- Each DaemonSet will only start pods on nodes with matching OS versions
+
+## Node Pool Requirements
+
+Your AKS cluster nodes must have the `kubernetes.azure.com/os-sku-effective` label set to one of:
+
+- `Ubuntu2204`
+- `Ubuntu2404`
+
+AKS automatically sets this label based on the node pool's OS configuration.
+
+## Image Tags
+
+Container images follow the pattern:
+
+- `mcr.microsoft.com/oss/v2/kubernetes-csi/azurelustre-csi:v0.4.0-jammy`
+- `mcr.microsoft.com/oss/v2/kubernetes-csi/azurelustre-csi:v0.4.0-noble`
+
+Each image contains an Ubuntu version capable of installing the Lustre client packages compiled for the target distribution.
+
+## Troubleshooting
+
+To check which nodes are running which versions:
+
+```bash
+kubectl get nodes -o custom-columns=NAME:.metadata.name,OS-SKU:.metadata.labels.'kubernetes\.azure\.com/os-sku-effective'
+```
+
+To check DaemonSet pod distribution:
+
+```bash
+kubectl get pods -n kube-system -l app=csi-azurelustre-node -l flavor=jammy -o wide
+kubectl get pods -n kube-system -l app=csi-azurelustre-node -l flavor=noble -o wide
+```