Merge pull request #1950 from andyzhangx/fix-goroutine-leak-1.24

[release-1.24] fix: goroutine leak when timeout

Author: andyzhangx

go.mod

@@ -155,6 +155,8 @@ require (
 	sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
 )
 
+require go.uber.org/goleak v1.3.0
+
 require (
 	github.com/Azure/azure-sdk-for-go/sdk/keyvault/azsecrets v0.12.0 // indirect
 	github.com/Azure/azure-sdk-for-go/sdk/keyvault/internal v0.7.1 // indirect

pkg/util/util.go

@@ -405,7 +405,7 @@ type TimeoutFunc func() (err error)
 // WaitUntilTimeout waits for the exec function to complete or return timeout error
 func WaitUntilTimeout(timeout time.Duration, execFunc ExecFunc, timeoutFunc TimeoutFunc) error {
 	// Create a channel to receive the result of the azcopy exec function
-	done := make(chan bool)
+	done := make(chan bool, 1)
 	var err error
 
 	// Start the azcopy exec function in a goroutine

pkg/util/util_test.go

@@ -24,6 +24,7 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/assert"
+	"go.uber.org/goleak"
 	"go.uber.org/mock/gomock"
 )
 
@@ -771,6 +772,7 @@ func TestSetVolumeOwnership(t *testing.T) {
 }
 
 func TestWaitUntilTimeout(t *testing.T) {
+	defer goleak.VerifyNone(t)
 	tests := []struct {
 		desc        string
 		timeout     time.Duration
@@ -797,6 +799,7 @@ func TestWaitUntilTimeout(t *testing.T) {
 				return nil
 			},
 			timeoutFunc: func() error {
+				time.Sleep(2 * time.Second)
 				return fmt.Errorf("timeout error")
 			},
 			expectedErr: fmt.Errorf("timeout error"),