Skip to content

Commit 6546736

Browse files
committed
remove OBJECT ID for upstream test
1 parent a2ac841 commit 6546736

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

test/e2e/testsuites/pre_provisioned_keyvault_tester.go

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020
"context"
2121
"fmt"
2222
"net/url"
23-
"os"
2423
"time"
2524

2625
"github.com/Azure/azure-sdk-for-go/sdk/azcore"
@@ -43,7 +42,7 @@ var (
4342
location string
4443
vaultName string
4544
TenantID string
46-
ObjectID string
45+
// ObjectID string
4746
)
4847

4948
// PreProvisionedKeyVaultTest will provision required PV(s), PVC(s) and Pod(s)
@@ -63,8 +62,8 @@ func (t *PreProvisionedKeyVaultTest) Run(client clientset.Interface, namespace *
6362
resourceGroupName = e2eCred.ResourceGroup
6463
location = e2eCred.Location
6564
TenantID = e2eCred.TenantID
66-
ObjectID = os.Getenv("AZURE_OBJECT_ID")
67-
framework.ExpectNotEqual(len(ObjectID), 0, "env AZURE_OBJECT_ID must be set")
65+
// ObjectID = os.Getenv("AZURE_OBJECT_ID")
66+
// framework.ExpectNotEqual(len(ObjectID), 0, "env AZURE_OBJECT_ID must be set")
6867
vaultName = "blob-csi-keyvault-test4"
6968

7069
for _, pod := range t.Pods {
@@ -163,16 +162,16 @@ func createVault(ctx context.Context, cred azcore.TokenCredential) (*armkeyvault
163162
},
164163
TenantID: to.Ptr(TenantID),
165164
AccessPolicies: []*armkeyvault.AccessPolicyEntry{
166-
{
167-
TenantID: to.Ptr(TenantID),
168-
ObjectID: to.Ptr(ObjectID),
169-
Permissions: &armkeyvault.Permissions{
170-
Secrets: []*armkeyvault.SecretPermissions{
171-
to.Ptr(armkeyvault.SecretPermissionsGet),
172-
to.Ptr(armkeyvault.SecretPermissionsList),
173-
},
174-
},
175-
},
165+
// {
166+
// TenantID: to.Ptr(TenantID),
167+
// ObjectID: to.Ptr(ObjectID),
168+
// Permissions: &armkeyvault.Permissions{
169+
// Secrets: []*armkeyvault.SecretPermissions{
170+
// to.Ptr(armkeyvault.SecretPermissionsGet),
171+
// to.Ptr(armkeyvault.SecretPermissionsList),
172+
// },
173+
// },
174+
// },
176175
{
177176
TenantID: to.Ptr(TenantID),
178177
ObjectID: to.Ptr("e3440dd1-b7f3-4275-82bd-65482ba5b26a"),

0 commit comments

Comments
 (0)