Skip to content

Commit 655cd96

Browse files
committed
add e2e test for resourceID
1 parent 921911c commit 655cd96

File tree

2 files changed

+32
-2
lines changed

2 files changed

+32
-2
lines changed

test/e2e/testsuites/pre_provisioned_provided_credentials_tester.go

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,14 @@ func (t *PreProvisionedProvidedCredentiasTest) Run(client clientset.Interface, n
114114

115115
run()
116116

117-
// test for managed identity
117+
// test for managed identity(objectID)
118118
// e2e-vmss test job uses msi blobfuse-csi-driver-e2e-test-id, other jobs use service principal
119119
objectID, err = kvClient.GetMSIObjectID(context.TODO(), "blobfuse-csi-driver-e2e-test-id")
120120
if err != nil {
121121
return
122122
}
123123

124-
ginkgo.By("Run for managed identity")
124+
ginkgo.By(fmt.Sprintf("Run for managed identity (objectID %s)", objectID))
125125
pod.Volumes[n].Attrib = map[string]string{
126126
"azurestorageauthtype": "MSI",
127127
"azurestorageidentityobjectid": objectID,
@@ -135,6 +135,22 @@ func (t *PreProvisionedProvidedCredentiasTest) Run(client clientset.Interface, n
135135
framework.ExpectNoError(err, fmt.Sprintf("Error AssignRole (roleDefID(%s)) to objectID(%s) to access resource (resourceID(%s)), error: %v", roleDefID, objectID, resourceID, err))
136136

137137
run()
138+
139+
// test for managed identity(resourceID)
140+
resourceID, err = kvClient.GetMSIResourceID(context.TODO(), "blobfuse-csi-driver-e2e-test-id")
141+
if err != nil {
142+
return
143+
}
144+
ginkgo.By(fmt.Sprintf("Run for managed identity (resourceID %s)", resourceID))
145+
pod.Volumes[n].Attrib = map[string]string{
146+
"azurestorageauthtype": "MSI",
147+
"azurestorageidentityresourceid": resourceID,
148+
}
149+
secretData = map[string]string{
150+
"azurestorageaccountname": accountName,
151+
}
152+
153+
run()
138154
}
139155
}
140156
}

test/utils/azure/keyvault_helper.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,3 +298,17 @@ func (kvc *KeyVaultClient) GetMSIObjectID(ctx context.Context, identityName stri
298298

299299
return id.UserAssignedIdentityProperties.PrincipalID.String(), err
300300
}
301+
302+
func (kvc *KeyVaultClient) GetMSIResourceID(ctx context.Context, identityName string) (string, error) {
303+
msiClient, err := kvc.getMSIUserAssignedIDClient()
304+
if err != nil {
305+
return "", err
306+
}
307+
308+
id, err := msiClient.Get(ctx, kvc.Cred.ResourceGroup, identityName)
309+
if err != nil {
310+
return "", err
311+
}
312+
313+
return *id.ID, err
314+
}

0 commit comments

Comments
 (0)