Merge pull request #2151 from andyzhangx/respect-secretName

andyzhangx · web-flow · commit 852afa28829f · 2025-08-28T13:22:17.000+08:00
fix: respect secretName during volume creation
diff --git a/pkg/blob/controllerserver.go b/pkg/blob/controllerserver.go
@@ -443,7 +443,7 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest)
 	}
 
 	accountOptions.Name = accountName
-	if len(secrets) == 0 && useDataPlaneAPI {
+	if len(secrets) == 0 && (useDataPlaneAPI || secretName != "") {
 		if accountKey == "" {
 			if accountName, accountKey, err = d.GetStorageAccesskey(ctx, accountOptions, secrets, secretName, secretNamespace); err != nil {
 				return nil, status.Errorf(codes.Internal, "failed to GetStorageAccesskey on account(%s) rg(%s), error: %v", accountOptions.Name, accountOptions.ResourceGroup, err)

Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ func (d Driver) CreateVolume(ctx context.Context, req csi.CreateVolumeRequest)`
`443`	`443`	`}`
`444`	`444`
`445`	`445`	`accountOptions.Name = accountName`
`446`		`- if len(secrets) == 0 && useDataPlaneAPI {`
	`446`	`+ if len(secrets) == 0 && (useDataPlaneAPI \|\| secretName != "") {`
`447`	`447`	`if accountKey == "" {`
`448`	`448`	`if accountName, accountKey, err = d.GetStorageAccesskey(ctx, accountOptions, secrets, secretName, secretNamespace); err != nil {`
`449`	`449`	`return nil, status.Errorf(codes.Internal, "failed to GetStorageAccesskey on account(%s) rg(%s), error: %v", accountOptions.Name, accountOptions.ResourceGroup, err)`