Skip to content

Commit 8d12648

Browse files
authored
Merge pull request #451 from andyzhangx/get-keyvault-logging
chore: add get key vault logs
2 parents ecd71b6 + 41fb2b8 commit 8d12648

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pkg/blob/azure.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,10 @@ func (d *Driver) getKeyVaultSecretContent(ctx context.Context, vaultURL string,
121121
return "", fmt.Errorf("failed to get keyvaultClient: %v", err)
122122
}
123123

124+
klog.V(2).Infof("get secret from vaultURL(%v), sercretName(%v), secretVersion(%v)", vaultURL, secretName, secretVersion)
124125
secret, err := kvClient.GetSecret(ctx, vaultURL, secretName, secretVersion)
125126
if err != nil {
126-
return "", fmt.Errorf("failed to use vaultURL(%v), sercretName(%v), secretVersion(%v) to get secret: %v", vaultURL, secretName, secretVersion, err)
127+
return "", fmt.Errorf("get secret from vaultURL(%v), sercretName(%v), secretVersion(%v) failed with error: %v", vaultURL, secretName, secretVersion, err)
127128
}
128129
return *secret.Value, nil
129130
}

pkg/blob/azure_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ func TestGetKeyVaultSecretContent(t *testing.T) {
235235
}
236236
d.cloud.AADClientID = "unit-test"
237237
d.cloud.AADClientSecret = "unit-test"
238-
expectedErr = fmt.Errorf("failed to use vaultURL(unit-test), sercretName(unit-test), secretVersion(v1) to get secret: keyvault.BaseClient#GetSecret: Failure preparing request: StatusCode=0 -- Original Error: autorest: No scheme detected in URL unit-test")
238+
expectedErr = fmt.Errorf("get secret from vaultURL(unit-test), sercretName(unit-test), secretVersion(v1) failed with error: keyvault.BaseClient#GetSecret: Failure preparing request: StatusCode=0 -- Original Error: autorest: No scheme detected in URL unit-test")
239239
_, err = d.getKeyVaultSecretContent(context.TODO(), valueURL, secretName, secretVersion)
240240
if !reflect.DeepEqual(expectedErr, err) {
241241
t.Errorf("actualErr: (%v), expectedErr: (%v)", err, expectedErr)

0 commit comments

Comments
 (0)