Merge pull request #162 from andyzhangx/remove-secret-logging

andyzhangx · web-flow · commit 929544e6f3d9 · 2020-06-06T13:47:56.000+08:00
fix: remove secret logging in NodeStageVolume
diff --git a/deploy/example/pv-blobfuse-csi.yaml b/deploy/example/pv-blobfuse-csi.yaml
@@ -15,7 +15,7 @@ spec:
   csi:
     driver: blobfuse.csi.azure.com
     readOnly: false
-    volumeHandle: uniqe-volumeid  # make sure this volumeid is unique in whole cluster
+    volumeHandle: uniqe-volumeid  # make sure this volumeid is unique in the cluster
     volumeAttributes:
       containerName: EXISTING_CONTAINER_NAME
     nodeStageSecretRef:
diff --git a/pkg/blobfuse/nodeserver.go b/pkg/blobfuse/nodeserver.go
@@ -103,7 +103,6 @@ func (d *Driver) NodeUnpublishVolume(ctx context.Context, req *csi.NodeUnpublish
 
 // NodeStageVolume mount the volume to a staging path
 func (d *Driver) NodeStageVolume(ctx context.Context, req *csi.NodeStageVolumeRequest) (*csi.NodeStageVolumeResponse, error) {
-	klog.V(2).Infof("NodeStageVolume: called with args %+v", *req)
 	if len(req.GetVolumeId()) == 0 {
 		return nil, status.Error(codes.InvalidArgument, "Volume ID missing in request")
 	}

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,6 @@ func (d Driver) NodeUnpublishVolume(ctx context.Context, req csi.NodeUnpublish`
`103`	`103`
`104`	`104`	`// NodeStageVolume mount the volume to a staging path`
`105`	`105`	`func (d Driver) NodeStageVolume(ctx context.Context, req csi.NodeStageVolumeRequest) (*csi.NodeStageVolumeResponse, error) {`
`106`		`- klog.V(2).Infof("NodeStageVolume: called with args %+v", *req)`
`107`	`106`	`if len(req.GetVolumeId()) == 0 {`
`108`	`107`	`return nil, status.Error(codes.InvalidArgument, "Volume ID missing in request")`
`109`	`108`	`}`