Skip to content

Commit 975c1c9

Browse files
authored
Merge pull request #232 from chewong/makefile-override
ci: allow override of IMAGE_TAG and E2E_HELM_OPTIONS in Makefile
2 parents 578423f + 1d8f6a5 commit 975c1c9

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,11 @@ ifndef PUBLISH
2424
override IMAGE_VERSION := e2e-$(GIT_COMMIT)
2525
endif
2626
endif
27-
IMAGE_TAG = $(REGISTRY)/$(IMAGE_NAME):$(IMAGE_VERSION)
27+
IMAGE_TAG ?= $(REGISTRY)/$(IMAGE_NAME):$(IMAGE_VERSION)
2828
IMAGE_TAG_LATEST = $(REGISTRY)/$(IMAGE_NAME):latest
2929
BUILD_DATE ?= $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
3030
LDFLAGS ?= "-X ${PKG}/pkg/blob.driverVersion=${IMAGE_VERSION} -X ${PKG}/pkg/blob.gitCommit=${GIT_COMMIT} -X ${PKG}/pkg/blob.buildDate=${BUILD_DATE} -s -w -extldflags '-static'"
31+
E2E_HELM_OPTIONS ?= --set image.blob.pullPolicy=IfNotPresent --set image.blob.repository=$(REGISTRY)/$(IMAGE_NAME) --set image.blob.tag=$(IMAGE_VERSION)
3132
GINKGO_FLAGS = -ginkgo.noColor -ginkgo.v
3233
GO111MODULE = off
3334
GOPATH ?= $(shell go env GOPATH)
@@ -62,9 +63,7 @@ e2e-bootstrap: install-helm
6263
# Only build and push the image if it does not exist in the registry
6364
docker pull $(IMAGE_TAG) || make blob-container push
6465
helm install charts/latest/blob-csi-driver -n blob-csi-driver --namespace kube-system --wait \
65-
--set image.blob.pullPolicy=IfNotPresent \
66-
--set image.blob.repository=$(REGISTRY)/$(IMAGE_NAME) \
67-
--set image.blob.tag=$(IMAGE_VERSION)
66+
$(E2E_HELM_OPTIONS)
6867

6968
.PHONY: install-helm
7069
install-helm:

0 commit comments

Comments
 (0)