Skip to content

Commit a5abd8b

Browse files
committed
feat: provide latency data in logs
1 parent e1a5967 commit a5abd8b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

pkg/blob/controllerserver.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,10 +255,11 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest)
255255
parameters[containerNameField] = validContainerName
256256
}
257257

258+
var volumeID string
258259
mc := metrics.NewMetricContext(blobCSIDriverName, "controller_create_volume", d.cloud.ResourceGroup, d.cloud.SubscriptionID, d.Name)
259260
isOperationSucceeded := false
260261
defer func() {
261-
mc.ObserveOperationWithResult(isOperationSucceeded)
262+
mc.ObserveOperationWithResult(isOperationSucceeded, volumeID, "")
262263
}()
263264

264265
klog.V(2).Infof("begin to create container(%s) on account(%s) type(%s) rg(%s) location(%s) size(%d)", validContainerName, accountName, storageAccountType, resourceGroup, location, requestGiB)
@@ -283,7 +284,7 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest)
283284
}
284285
}
285286

286-
volumeID := fmt.Sprintf(volumeIDTemplate, resourceGroup, accountName, validContainerName)
287+
volumeID = fmt.Sprintf(volumeIDTemplate, resourceGroup, accountName, validContainerName)
287288
if containerName != "" {
288289
// add volume name as suffix to differentiate volumeID since "containerName" is specified
289290
// not necessary for dynamic container name creation since volumeID already contains volume name
@@ -345,7 +346,7 @@ func (d *Driver) DeleteVolume(ctx context.Context, req *csi.DeleteVolumeRequest)
345346
mc := metrics.NewMetricContext(blobCSIDriverName, "controller_delete_volume", d.cloud.ResourceGroup, d.cloud.SubscriptionID, d.Name)
346347
isOperationSucceeded := false
347348
defer func() {
348-
mc.ObserveOperationWithResult(isOperationSucceeded)
349+
mc.ObserveOperationWithResult(isOperationSucceeded, volumeID, "")
349350
}()
350351

351352
klog.V(2).Infof("deleting container(%s) rg(%s) account(%s) volumeID(%s)", containerName, resourceGroupName, accountName, volumeID)

0 commit comments

Comments
 (0)