Skip to content

Commit b6528b2

Browse files
committed
fix: don't install blobfuse v1 by default since it's deprecated
1 parent e0b5383 commit b6528b2

File tree

7 files changed

+15
-3
lines changed

7 files changed

+15
-3
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ CSI_IMAGE_TAG ?= $(REGISTRY)/$(IMAGE_NAME):$(IMAGE_VERSION)
2929
CSI_IMAGE_TAG_LATEST = $(REGISTRY)/$(IMAGE_NAME):latest
3030
BUILD_DATE ?= $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
3131
LDFLAGS ?= "-X ${PKG}/pkg/blob.driverVersion=${IMAGE_VERSION} -X ${PKG}/pkg/blob.gitCommit=${GIT_COMMIT} -X ${PKG}/pkg/blob.buildDate=${BUILD_DATE} -s -w -extldflags '-static'"
32-
E2E_HELM_OPTIONS ?= --set image.blob.pullPolicy=Always --set image.blob.repository=$(REGISTRY)/$(IMAGE_NAME) --set image.blob.tag=$(IMAGE_VERSION) --set driver.userAgentSuffix="e2e-test"
32+
E2E_HELM_OPTIONS ?= --set image.blob.pullPolicy=Always --set image.blob.repository=$(REGISTRY)/$(IMAGE_NAME) --set image.blob.tag=$(IMAGE_VERSION) --set driver.userAgentSuffix="e2e-test" --set node.blobfuseProxy.migrateK8sRepo=true
3333
ifdef ENABLE_BLOBFUSE_PROXY
3434
override E2E_HELM_OPTIONS := $(E2E_HELM_OPTIONS) --set controller.logLevel=6 --set node.logLevel=6 --set node.enableBlobfuseProxy=true
3535
endif
37 Bytes
Binary file not shown.

charts/latest/blob-csi-driver/templates/csi-blob-node.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ spec:
100100
value: "{{ .Values.node.blobfuseProxy.maxOpenFileNum }}"
101101
- name: DISABLE_UPDATEDB
102102
value: "{{ .Values.node.blobfuseProxy.disableUpdateDB }}"
103+
- name: MIGRATE_K8S_REPO
104+
value: "{{ .Values.node.blobfuseProxy.migrateK8sRepo }}"
103105
volumeMounts:
104106
- name: host-usr
105107
mountPath: /host/usr

charts/latest/blob-csi-driver/values.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,14 @@ node:
119119
logLevel: 5
120120
enableBlobfuseProxy: true
121121
blobfuseProxy:
122-
installBlobfuse: true
122+
installBlobfuse: false
123123
blobfuseVersion: "1.4.5"
124124
installBlobfuse2: true
125125
blobfuse2Version: "2.3.2"
126126
setMaxOpenFileNum: true
127127
maxOpenFileNum: "9000000"
128128
disableUpdateDB: true
129+
migrateK8sRepo: false
129130
blobfuseCachePath: /mnt
130131
appendTimeStampInCacheDir: false
131132
mountPermissions: 0777

deploy/csi-blob-node.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ spec:
5555
- name: INSTALL_BLOBFUSE_PROXY
5656
value: "true"
5757
- name: INSTALL_BLOBFUSE
58-
value: "true"
58+
value: "false"
5959
- name: BLOBFUSE_VERSION
6060
value: "1.4.5"
6161
- name: INSTALL_BLOBFUSE2

pkg/blobfuse-proxy/init.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ INSTALL_BLOBFUSE_PROXY=${INSTALL_BLOBFUSE_PROXY:-true}
2020
DISABLE_UPDATEDB=${DISABLE_UPDATEDB:-true}
2121
SET_MAX_OPEN_FILE_NUM=${SET_MAX_OPEN_FILE_NUM:-true}
2222
SET_READ_AHEAD_SIZE=${SET_READ_AHEAD_SIZE:-true}
23+
MIGRATE_K8S_REPO=${MIGRATE_K8S_REPO:-false}
2324
READ_AHEAD_KB=${READ_AHEAD_KB:-15380}
2425

2526
HOST_CMD="nsenter --mount=/proc/1/ns/mnt"

pkg/blobfuse-proxy/install-proxy.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,14 @@ then
3333
else
3434
cp /blobfuse-proxy/packages-microsoft-prod-22.04.deb /host/etc/packages-microsoft-prod.deb
3535
fi
36+
37+
if [ "${MIGRATE_K8S_REPO}" = "true" ]
38+
then
39+
# https://kubernetes.io/blog/2023/08/15/pkgs-k8s-io-introduction/#how-to-migrate
40+
echo "deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/v1.30/deb/ /" | tee /host/etc/apt/sources.list.d/kubernetes.list
41+
$HOST_CMD curl -fsSL https://pkgs.k8s.io/core:/stable:/v1.30/deb/Release.key | $HOST_CMD gpg --dearmor -o /etc/apt/keyrings/kubernetes-apt-keyring.gpg
42+
fi
43+
3644
# when running dpkg -i /etc/packages-microsoft-prod.deb, need to enter y to continue.
3745
# refer to https://stackoverflow.com/questions/45349571/how-to-install-deb-with-dpkg-non-interactively
3846
yes | $HOST_CMD dpkg -i /etc/packages-microsoft-prod.deb && $HOST_CMD apt update

0 commit comments

Comments
 (0)