Skip to content

Commit f9b7871

Browse files
authored
Merge pull request #228 from andyzhangx/parameter-naming
doc: fix example docs
2 parents 15bafb5 + 291fea7 commit f9b7871

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ https://git.k8s.io/community/contributors/devel/release.md#issue-kind-label
1414
<!--
1515
Add one of the following kinds:
1616
/kind bug
17+
/kind test
1718
/kind cleanup
1819
/kind documentation
1920
/kind feature

deploy/example/e2e_usage.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ metadata:
2323
provisioner: blob.csi.azure.com
2424
parameters:
2525
resourceGroup: EXISTING_RESOURCE_GROUP_NAME
26-
storageAccount: EXISTING_STORAGE_ACCOUNT_NAME
26+
storageAccount: EXISTING_STORAGE_ACCOUNT_NAME # cross subscription is not supported
2727
containerName: EXISTING_CONTAINER_NAME
2828
reclaimPolicy: Retain # If set as "Delete" container would be removed after pvc deletion
2929
volumeBindingMode: Immediate
3030
```
31-
> As of this writing blob-csi-driver doesn't support storage accounts outside the cluster's subscription
31+
3232
```console
3333
kubectl create -f storageclass-blobfuse-existing-container.yaml
3434
```

deploy/example/storageclass-blobfuse-existing-container.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ metadata:
55
name: blob
66
provisioner: blob.csi.azure.com
77
parameters:
8-
resourceGroup: EXISTING_RESOURCE_GROUP
9-
storageAccount: EXISTING_STORAGE_ACCOUNT
8+
resourceGroup: EXISTING_RESOURCE_GROUP_NAME
9+
storageAccount: EXISTING_STORAGE_ACCOUNT_NAME
1010
containerName: EXISTING_CONTAINER_NAME
1111
server: SERVER_ADDRESS # optional, provide a new address to replace default "accountname.blob.core.windows.net"
1212
reclaimPolicy: Retain # if set as "Delete" container would be removed after pvc deletion

deploy/example/storageclass-blobfuse-msi.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ metadata:
55
name: blob
66
provisioner: blob.csi.azure.com
77
parameters:
8-
resourceGroup: EXISTING_RESOURCE_GROUP
9-
storageAccount: EXISTING_STORAGE_ACCOUNT
8+
resourceGroup: EXISTING_RESOURCE_GROUP_NAME
9+
storageAccount: EXISTING_STORAGE_ACCOUNT_NAME
1010
containerName: EXISTING_CONTAINER_NAME
1111
# refer to https://github.com/Azure/azure-storage-fuse#environment-variables
1212
AzureStorageIdentityClientID:

deploy/example/storageclass-blobfuse-readonly.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ metadata:
55
name: blob
66
provisioner: blob.csi.azure.com
77
parameters:
8-
resourceGroup: EXISTING_RESOURCE_GROUP
9-
storageAccount: EXISTING_STORAGE_ACCOUNT
8+
resourceGroup: EXISTING_RESOURCE_GROUP_NAME
9+
storageAccount: EXISTING_STORAGE_ACCOUNT_NAME
1010
containerName: EXISTING_CONTAINER_NAME
1111
reclaimPolicy: Retain # if set as "Delete" container would be removed after pvc deletion
1212
volumeBindingMode: Immediate

0 commit comments

Comments
 (0)