Skip to content

Eddie/dev/clb-combined-prs-outbound-synced #9489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 84 commits into
base: master
Choose a base branch
from
Open

Eddie/dev/clb-combined-prs-outbound-synced #9489

wants to merge 84 commits into from

Conversation

@georgeedward2000
Copy link
Contributor

@georgeedward2000 georgeedward2000 commented Sep 26, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

georgeedward2000 and others added 30 commits January 9, 2025 14:43
@georgeedward2000
Implement Pod BackendPool
9a5c9fd
@georgeedward2000
complete implementation CLB ReconcileBackendPools
e830609
@georgeedward2000
update getBackendPoolNameForCLBService
5e0729d
@georgeedward2000
complete implementation CLB GetBackendPrivateIPs
e3510f3
@georgeedward2000
Update NSG - CLB Load Balancer
66de73a
@georgeedward2000
Add unit tests for a part of CLB NSG flow + update CLB NSG implementa…
3f0f834 
…tion
@georgeedward2000
update nsg logic for clb + add/refactor tests
2ff6f2d
@georgeedward2000
Complete testing for Container Load Balancer BackendPool
807b4d6
@georgeedward2000
update CLB NSG to support dual-stack rules
182d11d
@georgeedward2000
add formation flow for clb lb rules
e9693c6
@georgeedward2000
comment typo
2a45c63
@georgeedward2000
named targetPort is not supported within CLB context
e1eb35d
@georgeedward2000
add unit tests
29bb3c8
@georgeedward2000
Implement Pod BackendPool
eae85c9
@georgeedward2000
complete implementation CLB ReconcileBackendPools
7737e3b
@georgeedward2000
update getBackendPoolNameForCLBService
b74ed14
@georgeedward2000
complete implementation CLB GetBackendPrivateIPs
6de9646
@georgeedward2000
Complete testing for Container Load Balancer BackendPool
0d329fb
@georgeedward2000
add formation flow for clb lb rules
f52242e
@georgeedward2000
comment typo
f51f58c
@georgeedward2000
named targetPort is not supported within CLB context
1027221
@georgeedward2000
add unit tests
8f489e7
@georgeedward2000
Update NSG - CLB Load Balancer
056ae46
@georgeedward2000
Add unit tests for a part of CLB NSG flow + update CLB NSG implementa…
8e0ad77 
…tion
@georgeedward2000
update nsg logic for clb + add/refactor tests
329464c
@georgeedward2000
update CLB NSG to support dual-stack rules
9e334c0
@georgeedward2000 @david-kow
Update internal/testutil/fixture/azure_managedcluster.go
9141356 
Co-authored-by: David Kowalski <[email protected]>
@georgeedward2000
Merge branch 'clb-backendpool' of https://github.com/david-kow/cloud-…
a0170f1 
…provider-azure into clb-backendpool
@georgeedward2000
update error message + return type
b2624b4
@georgeedward2000
update error message + return type
aa360af
@georgeedward2000
Added SGW API locally and generated azclient + created repo within cl…
491e8d9 
…oud provider for SGW operations
@georgeedward2000
Merge remote-tracking branch 'refs/remotes/origin/eddie/dev/clb-combi…
858f06a 
…ned-prs-outbound-synced' into eddie/dev/clb-combined-prs-outbound-synced
@georgeedward2000
wip - added sku in sgw api
b6077e0
@georgeedward2000
feat: Add Service Gateway support and refactor NRP service updates
a432779 
- Introduced GetServiceGatewayID method to construct the resource ID for the Service Gateway.
- Implemented UpdateNRPSGWServices and UpdateNRPSGWAddressLocations methods to handle updates for service gateways.
- Refactored location and service update logic in azure_location_and_nrp_service_batch_updater.go to utilize new methods for service gateway updates.
- Updated difftracker to include InitialSyncDone flag and modified ServiceDTO to use IsDelete instead of isDelete.
- Adjusted API version for NAT Gateway and Service Gateway clients to 2025-01-01.
- Added logging for service gateway updates and requests.
- Removed unused NRPAPIClientUpdateNRPLocations and NRPAPIClientUpdateNRPServices functions.
- Enhanced error handling and logging throughout the service gateway update process.
@georgeedward2000
feat: Implement disassociation of NAT Gateway from Service Gateway an…
4c07ab3 
…d add helper function to retrieve NAT Gateway
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 26, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/contains-merge-commits labels Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 26, 2025

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 26, 2025 •
edited
Loading

CLA Missing ID CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 26, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2025
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 26, 2025

Hi @georgeedward2000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 26, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 26, 2025
@georgeedward2000
checkpoint
fbe2c4f
@georgeedward2000
Refactor Service Gateway references to use dynamic resource name
96425d9
@georgeedward2000
feat: Implement Service Gateway attachment to subnet and ensure defau…
909ebe1 
…lt outbound service exists
@georgeedward2000
Refactor comments and formatting in YAML and inf packages
a7dc6ab 
- Adjusted comment formatting for consistency across multiple files in the YAML package, ensuring proper indentation and alignment.
- Updated comments in the inf package to enhance readability and maintain uniformity in style.
- Made minor adjustments to the code structure in various files to improve clarity and maintainability.
- Ensured that all comments follow a consistent format, particularly in the YAML parser and emitter files.
@georgeedward2000
Enhance service gateway existence check and configuration validation
a6e4f0f
@georgeedward2000
checkpoint: Enhance service gateway existence check and configuration…
7a28e59 
… validation
@georgeedward2000
wip
83d08cc
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: georgeedward2000
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

No one assigned

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/contains-merge-commits do-not-merge/needs-kind do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgeedward2000 @k8s-ci-robot