add business-name to isolate ELB instances in multiple clusters (#240)

Author: chengxiangdong

docs/huawei-cloud-controller-manager-configuration.md

@@ -1,4 +1,4 @@
-# Huawei Cloud Controller Manager Configurations
+_# Huawei Cloud Controller Manager Configurations
 
 There are 2 sets of configurations, as follows:
 
@@ -227,3 +227,10 @@ The following arguments are supported:
 
 * `disable-create-security-group` Optional. Disable automatic creation of security groups for ELB health checks.
   Valid values are `'true'` and `'false'`. The default is `'false'`.
+
+* `business-name` Optional. Business name or business identifier used to compose the name of the Huawei Cloud ELB instance.
+  To prevent the creation of ELB instances with the same name in Huawei Cloud when using the same tenant account in multiple K8s clusters,
+  which may ultimately cause CCM to malfunction. 
+  For example, `business-name: order-pass`, kubernetes loadbalancer service namespace/name: `default/order-service`,
+  then the name of the ELB instance is: `k8s_service_order-pass_default_order-service`.
+  > Changing this will create new ELB instances, the old ELB instances will not be deleted and no longer maintained.

pkg/cloudprovider/huaweicloud/dedicatedloadbalancer.go

@@ -104,6 +104,9 @@ func (d *DedicatedLoadBalancer) getLoadBalancerInstance(ctx context.Context, clu
 
 func (d *DedicatedLoadBalancer) GetLoadBalancerName(_ context.Context, clusterName string, service *v1.Service) string {
 	klog.Infof("GetLoadBalancerName: called with service %s/%s", service.Namespace, service.Name)
+	if d.loadbalancerOpts.BusinessName != "" {
+		clusterName = d.loadbalancerOpts.BusinessName
+	}
 	name := fmt.Sprintf("k8s_service_%s_%s_%s", clusterName, service.Namespace, service.Name)
 	return utils.CutString(name, defaultMaxNameLength)
 }

pkg/cloudprovider/huaweicloud/sharedloadbalancer.go

@@ -114,6 +114,9 @@ func (l *SharedLoadBalancer) getLoadBalancerInstance(ctx context.Context, cluste
 // *v1.Service parameter as read-only and not modify it.
 func (l *SharedLoadBalancer) GetLoadBalancerName(_ context.Context, clusterName string, service *v1.Service) string {
 	klog.Infof("GetLoadBalancerName: called with service %s/%s", service.Namespace, service.Name)
+	if l.loadbalancerOpts.BusinessName != "" {
+		clusterName = l.loadbalancerOpts.BusinessName
+	}
 	name := fmt.Sprintf("k8s_service_%s_%s_%s", clusterName, service.Namespace, service.Name)
 	return utils.CutString(name, defaultMaxNameLength)
 }

pkg/config/loadbalancerconfig.go

@@ -69,6 +69,7 @@ type LoadBalancerOptions struct {
 
 	DisableCreateSecurityGroup bool   `json:"disable-create-security-group"`
 	LoadBalancerClass          string `json:"loadbalancer-class"`
+	BusinessName               string `json:"business-name"`
 }
 
 type HealthCheckOption struct {