Skip to content

Commit 2b23ccc

Browse files
committed
Add common filter by manager function
1 parent bd1f88d commit 2b23ccc

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

controllers/helmreleasedrift/releasedrift_controller.go

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,24 @@ var excludeCreateEventsPredicate = predicate.Funcs{
4747
return false
4848
},
4949
UpdateFunc: func(e event.UpdateEvent) bool {
50-
mf := e.ObjectNew.GetManagedFields()
51-
mfl := len(mf)
52-
if mfl > 0 {
53-
manager := mf[mfl-1].Manager
54-
return !(manager == os.Args[0])
55-
}
50+
return shouldFilteredByManager(e.ObjectNew.GetManagedFields())
5651

57-
return false
5852
},
5953
DeleteFunc: func(e event.DeleteEvent) bool {
60-
return false
54+
return shouldFilteredByManager(e.Object.GetManagedFields())
6155
},
6256
}
6357

58+
func shouldFilteredByManager(mfs []metav1.ManagedFieldsEntry) bool {
59+
mfl := len(mfs)
60+
if mfl > 0 {
61+
manager := mfs[mfl-1].Manager
62+
return !(manager == os.Args[0])
63+
}
64+
65+
return false
66+
}
67+
6468
// setupWithManager sets up the controller with the Manager.
6569
func (r *releaseDriftReconciler) setupWithManager(mgr ctrl.Manager, gvks []schema.GroupVersionKind) error {
6670
controllerBuilder := ctrl.NewControllerManagedBy(mgr).

0 commit comments

Comments
 (0)