fixing reason names. updating condition message

Author: chaitanyakolluru

api/v1alpha1/condition_consts.go

@@ -42,13 +42,13 @@ const (
 	// ClusterSelectionFailedReason indicates that the HelmChartProxy controller failed to select the workload Clusters.
 	ClusterSelectionFailedReason = "ClusterSelectionFailed"
 
-	// HelmReleaseProxiesRolloutNotReady indicates that the initial rollout
+	// HelmReleaseProxiesRolloutNotCompleteReason indicates that the initial rollout
 	// of HelmReleaseProxies has not been completed.
-	HelmReleaseProxiesRolloutNotReady = "HelmReleaseProxiesRolloutNotReady"
+	HelmReleaseProxiesRolloutNotCompleteReason = "HelmReleaseProxiesRolloutNotComplete"
 
-	// HelmReleaseProxiesRolloutUndefined indicates that HelmChartProxy doesn't
+	// HelmReleaseProxiesRolloutUndefinedReason indicates that HelmChartProxy doesn't
 	// use Rollout Step Size to reconcile HelmReleaseProxies.
-	HelmReleaseProxiesRolloutUndefined = "HelmReleaseProxiesRolloutUndefined"
+	HelmReleaseProxiesRolloutUndefinedReason = "HelmReleaseProxiesRolloutUndefined"
 
 	// HelmReleaseProxiesReadyCondition indicates that the HelmReleaseProxies are ready, meaning that the Helm installation, upgrade
 	// or deletion is complete.

controllers/helmchartproxy/helmchartproxy_controller.go

@@ -218,7 +218,7 @@ func (r *HelmChartProxyReconciler) reconcileNormal(ctx context.Context, helmChar
 			conditions.MarkFalse(
 				helmChartProxy,
 				addonsv1alpha1.HelmReleaseProxiesRolloutCompletedCondition,
-				addonsv1alpha1.HelmReleaseProxiesRolloutNotReady,
+				addonsv1alpha1.HelmReleaseProxiesRolloutNotCompleteReason,
 				clusterv1.ConditionSeverityInfo,
 				"%d Helm release proxies not yet rolled out",
 				len(clusters)-len(helmReleaseProxies),
@@ -297,9 +297,9 @@ func (r *HelmChartProxyReconciler) reconcileNormal(ctx context.Context, helmChar
 		conditions.MarkTrueWithNegativePolarity(
 			helmChartProxy,
 			addonsv1alpha1.HelmReleaseProxiesRolloutCompletedCondition,
-			addonsv1alpha1.HelmReleaseProxiesRolloutUndefined,
+			addonsv1alpha1.HelmReleaseProxiesRolloutUndefinedReason,
 			clusterv1.ConditionSeverityInfo,
-			"HelmChartProxy does not use Rollout Step Size",
+			"HelmChartProxy does not use rollout step",
 		)
 	}