Do not allow negative prefix

Author: mcbenjemaa

api/v1alpha2/inclusterippool_types.go

@@ -28,6 +28,7 @@ type InClusterIPPoolSpec struct {
 
 	// Prefix is the network prefix to use.
 	// +kubebuilder:validation:Maximum=128
+	// +kubebuilder:validation:Minimum=0
 	Prefix int `json:"prefix"`
 
 	// Gateway

config/crd/bases/ipam.cluster.x-k8s.io_globalinclusterippools.yaml

@@ -217,6 +217,7 @@ spec:
               prefix:
                 description: Prefix is the network prefix to use.
                 maximum: 128
+                minimum: 0
                 type: integer
             required:
             - addresses

config/crd/bases/ipam.cluster.x-k8s.io_inclusterippools.yaml

@@ -215,6 +215,7 @@ spec:
               prefix:
                 description: Prefix is the network prefix to use.
                 maximum: 128
+                minimum: 0
                 type: integer
             required:
             - addresses

internal/webhooks/inclusterippool.go

@@ -185,6 +185,10 @@ func (webhook *InClusterIPPool) validate(_, newPool types.GenericInClusterPool)
 		allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "addresses"), newPool.PoolSpec().Addresses, "addresses is required"))
 	}
 
+	if newPool.PoolSpec().Prefix < 0 {
+		allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "prefix"), newPool.PoolSpec().Addresses, "a valid prefix is required"))
+	}
+
 	var hasIPv4Addr, hasIPv6Addr bool
 	for _, address := range newPool.PoolSpec().Addresses {
 		ipSet, err := poolutil.AddressToIPSet(address)

internal/webhooks/inclusterippool_test.go

@@ -418,6 +418,18 @@ func TestInvalidScenarios(t *testing.T) {
 			},
 			expectedError: "provided address is not a valid IP, range, nor CIDR",
 		},
+		{
+			testcase: "negative prefix not allowed",
+			spec: v1alpha2.InClusterIPPoolSpec{
+				Addresses: []string{
+					"10.0.0.25",
+					"10.0.0.26",
+				},
+				Prefix:  -1,
+				Gateway: "10.0.0.1",
+			},
+			expectedError: "a valid prefix is required",
+		},
 		{
 			testcase: "specifying an invalid prefix",
 			spec: v1alpha2.InClusterIPPoolSpec{