build: bump development and testing tools

Update various development, build, and testing tools to their latest versions:

- controller-gen: v0.16.1 → v0.19.0
- golangci-lint: v2.1.0 → v2.5.0
- kustomize: v5.3.0 → v5.7.1
- gotestsum: v1.11.0 → v1.13.0
- ginkgo: v2.22.2 → v2.25.3
- helm: v3.14.4 → v3.19.0
- yq: v4.35.2 → v4.47.2
- conversion-gen: v0.29.2 → v0.34.1
- conversion-verifier: v1.7.0 → v1.11.1
- cert-manager: v1.15.1 → v1.16.1

Additionally, this commit includes minor code improvements:
- Fix implicit return to explicit return nil in manifests_downloader.go
- Add context to exec.CommandContext in test framework

These updates ensure compatibility with latest tooling and address potential
linting issues from newer versions.

Author: Fedosin

.github/workflows/golangci-lint.yml

@@ -23,11 +23,11 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # tag=v8.0.0
         with:
-          version: v2.1.0
+          version: v2.5.0
           args: --timeout 15m
       - name: golangci-lint-test
         uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # tag=v8.0.0
         with:
-          version: v2.1.0
+          version: v2.5.0
           args: --build-tags e2e --timeout 15m
           working-directory: test

Makefile

@@ -79,15 +79,15 @@ IMAGE_REVIEWERS ?= $(shell ./hack/get-project-maintainers.sh)
 
 # Binaries.
 # Need to use abspath so we can invoke these from subdirectories
-CONTROLLER_GEN_VER := v0.16.1
+CONTROLLER_GEN_VER := v0.19.0
 CONTROLLER_GEN_BIN := controller-gen
 CONTROLLER_GEN := $(TOOLS_BIN_DIR)/$(CONTROLLER_GEN_BIN)-$(CONTROLLER_GEN_VER)
 
-GOLANGCI_LINT_VER := v2.0.2
+GOLANGCI_LINT_VER := v2.5.0
 GOLANGCI_LINT_BIN := golangci-lint
 GOLANGCI_LINT := $(TOOLS_BIN_DIR)/$(GOLANGCI_LINT_BIN)-$(GOLANGCI_LINT_VER)
 
-KUSTOMIZE_VER := v5.3.0
+KUSTOMIZE_VER := v5.7.1
 KUSTOMIZE_BIN := kustomize
 KUSTOMIZE := $(TOOLS_BIN_DIR)/$(KUSTOMIZE_BIN)-$(KUSTOMIZE_VER)
 
@@ -99,11 +99,11 @@ SETUP_ENVTEST_VER := v0.0.0-20240522175850-2e9781e9fc60
 SETUP_ENVTEST_BIN := setup-envtest
 SETUP_ENVTEST := $(TOOLS_BIN_DIR)/$(SETUP_ENVTEST_BIN)-$(SETUP_ENVTEST_VER)
 
-GOTESTSUM_VER := v1.11.0
+GOTESTSUM_VER := v1.13.0
 GOTESTSUM_BIN := gotestsum
 GOTESTSUM := $(TOOLS_BIN_DIR)/$(GOTESTSUM_BIN)-$(GOTESTSUM_VER)
 
-GINKGO_VER := v2.22.2
+GINKGO_VER := v2.25.3
 GINKGO_BIN := ginkgo
 GINKGO := $(TOOLS_BIN_DIR)/$(GINKGO_BIN)-$(GINKGO_VER)
 
@@ -115,23 +115,23 @@ GO_APIDIFF_VER := v0.8.3
 GO_APIDIFF_BIN := go-apidiff
 GO_APIDIFF := $(TOOLS_BIN_DIR)/$(GO_APIDIFF_BIN)-$(GO_APIDIFF_VER)
 
-HELM_VER := v3.14.4
+HELM_VER := v3.19.0
 HELM_BIN := helm
 HELM := $(TOOLS_BIN_DIR)/$(HELM_BIN)-$(HELM_VER)
 
-YQ_VER := v4.35.2
+YQ_VER := v4.47.2
 YQ_BIN := yq
 YQ := $(TOOLS_BIN_DIR)/$(YQ_BIN)-$(YQ_VER)
 
 KPROMO_VER := v4.0.5
 KPROMO_BIN := kpromo
 KPROMO :=  $(TOOLS_BIN_DIR)/$(KPROMO_BIN)-$(KPROMO_VER)
 
-CONVERSION_GEN_VER := v0.29.2
+CONVERSION_GEN_VER := v0.34.1
 CONVERSION_GEN_BIN := conversion-gen
 CONVERSION_GEN := $(TOOLS_BIN_DIR)/$(CONVERSION_GEN_BIN)-$(CONVERSION_GEN_VER)
 
-CONVERSION_VERIFIER_VER := v1.7.0
+CONVERSION_VERIFIER_VER := v1.11.1
 CONVERSION_VERIFIER_BIN := conversion-verifier
 CONVERSION_VERIFIER := $(TOOLS_BIN_DIR)/$(CONVERSION_VERIFIER_BIN)-$(CONVERSION_VERIFIER_VER)
 
@@ -157,7 +157,7 @@ CONTROLLER_IMG_TAG ?= $(CONTROLLER_IMG)-$(ARCH):$(TAG)
 LDFLAGS := $(shell $(ROOT)/hack/version.sh)
 
 # Default cert-manager version
-CERT_MANAGER_VERSION ?= v1.15.1
+CERT_MANAGER_VERSION ?= v1.16.1
 
 # E2E configuration
 GINKGO_NOCOLOR ?= false

config/crd/bases/operator.cluster.x-k8s.io_addonproviders.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.1
+    controller-gen.kubebuilder.io/version: v0.19.0
   name: addonproviders.operator.cluster.x-k8s.io
 spec:
   group: operator.cluster.x-k8s.io

config/crd/bases/operator.cluster.x-k8s.io_bootstrapproviders.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.1
+    controller-gen.kubebuilder.io/version: v0.19.0
   name: bootstrapproviders.operator.cluster.x-k8s.io
 spec:
   group: operator.cluster.x-k8s.io

config/crd/bases/operator.cluster.x-k8s.io_controlplaneproviders.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.1
+    controller-gen.kubebuilder.io/version: v0.19.0
   name: controlplaneproviders.operator.cluster.x-k8s.io
 spec:
   group: operator.cluster.x-k8s.io

config/crd/bases/operator.cluster.x-k8s.io_coreproviders.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.1
+    controller-gen.kubebuilder.io/version: v0.19.0
   name: coreproviders.operator.cluster.x-k8s.io
 spec:
   group: operator.cluster.x-k8s.io

config/crd/bases/operator.cluster.x-k8s.io_infrastructureproviders.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.1
+    controller-gen.kubebuilder.io/version: v0.19.0
   name: infrastructureproviders.operator.cluster.x-k8s.io
 spec:
   group: operator.cluster.x-k8s.io

config/crd/bases/operator.cluster.x-k8s.io_ipamproviders.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.1
+    controller-gen.kubebuilder.io/version: v0.19.0
   name: ipamproviders.operator.cluster.x-k8s.io
 spec:
   group: operator.cluster.x-k8s.io

config/crd/bases/operator.cluster.x-k8s.io_runtimeextensionproviders.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.1
+    controller-gen.kubebuilder.io/version: v0.19.0
   name: runtimeextensionproviders.operator.cluster.x-k8s.io
 spec:
   group: operator.cluster.x-k8s.io

internal/controller/manifests_downloader.go

@@ -229,7 +229,7 @@ func compressData(componentsBuf *bytes.Buffer, data []byte) (err error) {
 		return fmt.Errorf("cannot compress data: %w", err)
 	}
 
-	return
+	return nil
 }
 
 // decompressData takes a compressed data, and decompresses it.