Skip to content

Commit cc7397b

Browse files
committed
chore: use genericProviderList type to avoid casting twice
1 parent 53b604a commit cc7397b

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

util/util.go

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,20 +77,15 @@ func GetCustomProviders(ctx context.Context, cl ctrlclient.Client, currProvider
7777
currProviderType := currProvider.GetType()
7878

7979
for _, providerList := range operatorv1.ProviderLists {
80-
providerList, ok := providerList.(ctrlclient.ObjectList)
80+
genericProviderList, ok := providerList.(genericProviderList)
8181
if !ok {
82-
return nil, fmt.Errorf("cannot cast providers list to ObjectList")
82+
return nil, fmt.Errorf("cannot cast providers list to genericProviderList")
8383
}
8484

85-
if err := cl.List(ctx, providerList); err != nil {
85+
if err := cl.List(ctx, genericProviderList); err != nil {
8686
return nil, fmt.Errorf("cannot get a list of providers from the server: %w", err)
8787
}
8888

89-
genericProviderList, ok := providerList.(operatorv1.GenericProviderList)
90-
if !ok {
91-
return nil, fmt.Errorf("cannot cast providers list to GenericProviderList")
92-
}
93-
9489
genericProviderListItems := genericProviderList.GetItems()
9590
for i, provider := range genericProviderListItems {
9691
if provider.GetName() == currProviderName && provider.GetType() == currProviderType || provider.GetSpec().FetchConfig == nil {

0 commit comments

Comments
 (0)