🐛: elbv2: fix checking for existing listeners

We were comparing pointers that were never going to be equal. Let's
check their pointed-to values instead.

Also added a break when the listener is found.

Changed the `createdListeners` list to only include a listener if it was
created. This list is currently not used for anything, so this change
should have no impact.

Author: r4f4

pkg/cloud/services/elb/loadbalancer.go

@@ -1604,8 +1604,9 @@ func (s *Service) reconcileTargetGroupsAndListeners(lbARN string, spec *infrav1.
 
 		var listener *elbv2.Listener
 		for _, l := range existingListeners.Listeners {
-			if l.DefaultActions != nil && len(l.DefaultActions) > 0 && l.DefaultActions[0].TargetGroupArn == group.TargetGroupArn {
+			if l.DefaultActions != nil && len(l.DefaultActions) > 0 && *l.DefaultActions[0].TargetGroupArn == *group.TargetGroupArn {
 				listener = l
+				break
 			}
 		}
 
@@ -1614,9 +1615,8 @@ func (s *Service) reconcileTargetGroupsAndListeners(lbARN string, spec *infrav1.
 			if err != nil {
 				return nil, nil, err
 			}
+			createdListeners = append(createdListeners, listener)
 		}
-
-		createdListeners = append(createdListeners, listener)
 	}
 
 	return createdTargetGroups, createdListeners, nil