Skip to content

Commit 1530117

Browse files
authored
Merge pull request #3186 from DiptoChakrabarty/errwrap
Use Wrapf for errors only when err is not nil
2 parents e8025e5 + d58189a commit 1530117

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

pkg/cloud/services/eks/fargate.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ func (s *FargateService) reconcileFargateProfile() (requeue bool, err error) {
104104
tagKey := infrav1.ClusterAWSCloudProviderTagKey(s.scope.ClusterName())
105105
ownedTag := profile.Tags[tagKey]
106106
if ownedTag == nil {
107-
return false, errors.Wrapf(err, "owned tag not found for this cluster")
107+
return false, errors.New("owned tag not found for this cluster")
108108
}
109109
s.scope.V(2).Info("Found owned EKS fargate profile", "cluster-name", eksClusterName, "profile-name", profileName)
110110
}

pkg/cloud/services/eks/nodegroup.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ func (s *NodegroupService) reconcileNodegroup() error {
484484
tagKey := infrav1.ClusterAWSCloudProviderTagKey(s.scope.ClusterName())
485485
ownedTag := ng.Tags[tagKey]
486486
if ownedTag == nil {
487-
return errors.Wrapf(err, "owner of %s mismatch: %s", eksNodegroupName, s.scope.ClusterName())
487+
return errors.Errorf("owner of %s mismatch: %s", eksNodegroupName, s.scope.ClusterName())
488488
}
489489
s.scope.V(2).Info("Found owned EKS nodegroup in AWS", "cluster-name", eksClusterName, "nodegroup-name", eksNodegroupName)
490490
}

pkg/cloud/services/network/natgateways.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ func (s *Service) deleteNatGateway(id string) error {
287287
}
288288

289289
if len(out.NatGateways) == 0 {
290-
return false, errors.Wrapf(err, "no NAT gateway returned for id %q", id)
290+
return false, errors.New(fmt.Sprintf("no NAT gateway returned for id %q", id))
291291
}
292292

293293
ng := out.NatGateways[0]

0 commit comments

Comments
 (0)