Skip to content

Commit 16b98c3

Browse files
committed
refactor: simplify ingressrules
1 parent d032bbe commit 16b98c3

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

pkg/cloud/services/securitygroup/securitygroups.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -682,12 +682,11 @@ func (s *Service) getSecurityGroupIngressRules(role infrav1.SecurityGroupRole) (
682682
}
683683
return append(cniRules, rules...), nil
684684
case infrav1.SecurityGroupEKSNodeAdditional:
685-
rules := infrav1.IngressRules{}
685+
ingressRules := s.scope.AdditionalControlPlaneIngressRules()
686686
if s.scope.Bastion().Enabled {
687-
rules = append(rules, s.defaultSSHIngressRule(s.scope.SecurityGroups()[infrav1.SecurityGroupBastion].ID))
687+
ingressRules = append(ingressRules, s.defaultSSHIngressRule(s.scope.SecurityGroups()[infrav1.SecurityGroupBastion].ID))
688688
}
689-
ingressRules := s.scope.AdditionalControlPlaneIngressRules()
690-
return append(rules, ingressRules...), nil
689+
return ingressRules, nil
691690
case infrav1.SecurityGroupAPIServerLB:
692691
kubeletRules := s.getIngressRulesToAllowKubeletToAccessTheControlPlaneLB()
693692
customIngressRules, err := s.processIngressRulesSGs(s.getControlPlaneLBIngressRules())

0 commit comments

Comments
 (0)