Expose Metrics port

This PR exposes the Metrics port of the CAPA main controller.

Author: Skarlso

config/default/kustomization.yaml

@@ -7,6 +7,7 @@ commonLabels:
 resources:
 - namespace.yaml
 - credentials.yaml
+- metrics_service.yaml
 
 bases:
 - ../rbac

config/default/metrics_service.yaml

@@ -0,0 +1,13 @@
+apiVersion: v1
+kind: Service
+metadata:
+  name: metrics-service
+  namespace: system
+spec:
+  selector:
+    cluster.x-k8s.io/provider: infrastructure-aws
+  ports:
+    - port: 8080
+      targetPort: metrics
+      protocol: TCP
+  type: ClusterIP

config/manager/manager.yaml

@@ -21,7 +21,7 @@ spec:
         - "--leader-elect"
         - "--feature-gates=EKS=${CAPA_EKS:=true},EKSEnableIAM=${CAPA_EKS_IAM:=false},EKSAllowAddRoles=${CAPA_EKS_ADD_ROLES:=false},EKSFargate=${EXP_EKS_FARGATE:=false},MachinePool=${EXP_MACHINE_POOL:=false},EventBridgeInstanceState=${EVENT_BRIDGE_INSTANCE_STATE:=false},AutoControllerIdentityCreator=${AUTO_CONTROLLER_IDENTITY_CREATOR:=true},BootstrapFormatIgnition=${EXP_BOOTSTRAP_FORMAT_IGNITION:=false},ExternalResourceGC=${EXP_EXTERNAL_RESOURCE_GC:=false}"
         - "--v=${CAPA_LOGLEVEL:=0}"
-        - "--metrics-bind-addr=127.0.0.1:8080"
+        - "--metrics-bind-addr=0.0.0.0:8080"
         image: controller:latest
         imagePullPolicy: Always
         name: manager

pkg/cloud/logs/logs.go

@@ -57,9 +57,6 @@ func (l *logrWrapper) Log(msgs ...interface{}) {
 	case 1:
 		l.log.Info(msgs[0].(string))
 	default:
-		// Even the previous implementation had this problem but because it wasn't a direct
-		// logr.Logger thing, it didn't say this...
-		//nolint: logrlint
 		l.log.Info(msgs[0].(string), msgs[:1]...)
 	}
 }