Functioning Sec Groups E2E test and refactor AWS infrastructure functions

Add additional filter to getSubnetID function based on clusterName

Apply suggestions from code review

Co-authored-by: sedefsavas <[email protected]>

Author: Josh Ferrell

test/e2e/data/e2e_conf.yaml

@@ -224,6 +224,8 @@ providers:
           - sourcePath: "./infrastructure-aws/generated/cluster-template.yaml"
           - sourcePath: "./infrastructure-aws/generated/cluster-template-gpu.yaml"
           - sourcePath: "./infrastructure-aws/generated/cluster-template-upgrades.yaml"
+          - sourcePath: "./infrastructure-aws/generated/cluster-template-external-infrastructure.yaml"
+          - sourcePath: "./infrastructure-aws/generated/cluster-template-external-securitygroups.yaml"
           - sourcePath: "./infrastructure-aws/kustomize_sources/topology/clusterclass-quick-start.yaml"
           - sourcePath: "./shared/v1beta1_provider/metadata.yaml"
         replacements:

test/e2e/data/infrastructure-aws/kustomize_sources/external-infrastructure/kustomization.yaml

@@ -0,0 +1,5 @@
+resources:
+  - ../limit-az
+patchesStrategicMerge:
+  - patches/external-infrastructure.yaml
+  

test/e2e/data/infrastructure-aws/kustomize_sources/external-infrastructure/patches/external-infrastructure.yaml

@@ -0,0 +1,12 @@
+apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
+kind: AWSCluster
+metadata:
+  name: "${CLUSTER_NAME}"
+spec:
+  network:
+    vpc:
+      id: "${VPC_ID}"
+    subnets:
+    - id: "${PUBLIC_SUBNET_ID}"
+    - id: "${PRIVATE_SUBNET_ID}"
+    

test/e2e/data/infrastructure-aws/kustomize_sources/external-securitygroups/kustomization.yaml

@@ -0,0 +1,5 @@
+resources:
+  - ../external-infrastructure
+patchesStrategicMerge:
+  - patches/external-securitygroups.yaml
+  

test/e2e/data/infrastructure-aws/kustomize_sources/external-securitygroups/patches/external-securitygroups.yaml

@@ -0,0 +1,12 @@
+apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
+kind: AWSCluster
+metadata:
+  name: "${CLUSTER_NAME}"
+spec:
+  network:
+    securityGroupOverrides:
+      controlplane: "${CP_SG_ID}"
+      apiserver-lb: "${API_SG_ID}"
+      node: "${NODE_SG_ID}"
+      lb: "${LB_SG_ID}"
+