Re-order reconcile steps.

The Identity provider needs the S3 objects, so let's create them first and avoid flakey failures.

Author: sl1pm4t

pkg/cloud/services/iam/iam.go

@@ -76,20 +76,20 @@ func (s *Service) ReconcileOIDCProvider(ctx context.Context) error {
 		return errors.New("s3 bucket configuration required to associate OIDC provider")
 	}
 
-	if err := s.reconcileIdentityProvider(ctx); err != nil {
+	if err := s.reconcileBucketContents(ctx); err != nil {
 		return err
 	}
 
-	if err := s.reconcileBucketContents(ctx); err != nil {
+	if err := s.reconcileIdentityProvider(ctx); err != nil {
 		return err
 	}
 
+	conditions.MarkTrue(s.scope.InfraCluster(), infrav1.OIDCProviderReadyCondition)
+
 	if err := s.reconcileTrustPolicyConfigMap(ctx); err != nil {
 		return fmt.Errorf("failed to reconcile trust policy config map: %w", err)
 	}
 
-	conditions.MarkTrue(s.scope.InfraCluster(), infrav1.OIDCProviderReadyCondition)
-
 	return nil
 }