Merge pull request #5523 from AndiDog/awsmachinepool-minsize-fix

k8s-ci-robot · web-flow · commit 4a657f8ca153 · 2025-06-04T04:08:37.000-07:00
🐛 Fix determined value for `MinSize` field of ASG
diff --git a/pkg/cloud/services/autoscaling/autoscalinggroup.go b/pkg/cloud/services/autoscaling/autoscalinggroup.go
@@ -50,7 +50,7 @@ func (s *Service) SDKToAutoScalingGroup(v *autoscalingtypes.AutoScalingGroup) (*
 		// TODO(rudoi): this is just terrible
 		DesiredCapacity:   v.DesiredCapacity,
 		MaxSize:           aws.Int32Value(v.MaxSize), //#nosec G115
-		MinSize:           aws.Int32Value(v.MaxSize), //#nosec G115
+		MinSize:           aws.Int32Value(v.MinSize), //#nosec G115
 		CapacityRebalance: aws.BoolValue(v.CapacityRebalance),
 		// TODO: determine what additional values go here and what else should be in the struct
 	}

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func (s Service) SDKToAutoScalingGroup(v autoscalingtypes.AutoScalingGroup) (*`
`50`	`50`	`// TODO(rudoi): this is just terrible`
`51`	`51`	`DesiredCapacity: v.DesiredCapacity,`
`52`	`52`	`MaxSize: aws.Int32Value(v.MaxSize), //#nosec G115`
`53`		`- MinSize: aws.Int32Value(v.MaxSize), //#nosec G115`
	`53`	`+ MinSize: aws.Int32Value(v.MinSize), //#nosec G115`
`54`	`54`	`CapacityRebalance: aws.BoolValue(v.CapacityRebalance),`
`55`	`55`	`// TODO: determine what additional values go here and what else should be in the struct`
`56`	`56`	`}`