added unit test

Author: muraee

exp/controllers/rosamachinepool_controller.go

@@ -423,7 +423,7 @@ func nodePoolBuilder(rosaMachinePoolSpec expinfrav1.RosaMachinePoolSpec, machine
 func nodePoolToRosaMachinePoolSpec(nodePool *cmv1.NodePool) expinfrav1.RosaMachinePoolSpec {
 	spec := expinfrav1.RosaMachinePoolSpec{
 		NodePoolName:     nodePool.ID(),
-		Version:          nodePool.Version().RawID(),
+		Version:          rosa.RawVersionID(nodePool.Version()),
 		AvailabilityZone: nodePool.AvailabilityZone(),
 		Subnet:           nodePool.Subnet(),
 		Labels:           nodePool.Labels(),

exp/controllers/rosamachinepool_controller_test.go

@@ -0,0 +1,37 @@
+package controllers
+
+import (
+	"testing"
+
+	. "github.com/onsi/gomega"
+	"k8s.io/utils/ptr"
+
+	expinfrav1 "sigs.k8s.io/cluster-api-provider-aws/v2/exp/api/v1beta2"
+	expclusterv1 "sigs.k8s.io/cluster-api/exp/api/v1beta1"
+)
+
+func TestNodePoolToRosaMachinePoolSpec(t *testing.T) {
+	g := NewWithT(t)
+
+	rosaMachinePoolSpec := expinfrav1.RosaMachinePoolSpec{
+		NodePoolName:  "test-nodepool",
+		Version:       "4.14.5",
+		Subnet:        "subnet-id",
+		AutoRepair:    true,
+		InstanceType:  "m5.large",
+		TuningConfigs: []string{"config1"},
+	}
+
+	machinePoolSpec := expclusterv1.MachinePoolSpec{
+		Replicas: ptr.To[int32](2),
+	}
+
+	nodePoolBuilder := nodePoolBuilder(rosaMachinePoolSpec, machinePoolSpec)
+
+	nodePoolSpec, err := nodePoolBuilder.Build()
+	g.Expect(err).ToNot(HaveOccurred())
+
+	expectedSpec := nodePoolToRosaMachinePoolSpec(nodePoolSpec)
+
+	g.Expect(expectedSpec).To(Equal(rosaMachinePoolSpec))
+}