Merge pull request #4077 from Skarlso/add_error_output

chore(ref): add output of error for role deletion

Author: k8s-ci-robot

test/e2e/shared/aws.go

@@ -477,6 +477,9 @@ func deleteResourcesInCloudFormation(prov client.ConfigProvider, t *cfn_bootstra
 			By(fmt.Sprintf("cleanup for role with name '%s'", role.RoleName))
 			Eventually(func(gomega Gomega) bool {
 				_, err := iamSvc.DeleteRole(&iam.DeleteRoleInput{RoleName: aws.String(role.RoleName)})
+				if err != nil {
+					By(fmt.Sprintf("failed to delete role '%s'; reason: %s", role.RoleName, err.Error()))
+				}
 				return awserrors.IsNotFound(err) || err == nil
 			}, 5*time.Minute, 5*time.Second).Should(BeTrue())
 		}
@@ -485,6 +488,9 @@ func deleteResourcesInCloudFormation(prov client.ConfigProvider, t *cfn_bootstra
 			By(fmt.Sprintf("cleanup for profile with name '%s'", profile.InstanceProfileName))
 			Eventually(func(gomega Gomega) bool {
 				_, err := iamSvc.DeleteInstanceProfile(&iam.DeleteInstanceProfileInput{InstanceProfileName: aws.String(profile.InstanceProfileName)})
+				if err != nil {
+					By(fmt.Sprintf("failed to delete role '%s'; reason: %s", profile.InstanceProfileName, err.Error()))
+				}
 				return awserrors.IsNotFound(err) || err == nil
 			}, 5*time.Minute, 5*time.Second).Should(BeTrue())
 		}
@@ -498,6 +504,9 @@ func deleteResourcesInCloudFormation(prov client.ConfigProvider, t *cfn_bootstra
 						By(fmt.Sprintf("cleanup for policy '%s'", p.String()))
 						Eventually(func(gomega Gomega) bool {
 							_, err := iamSvc.DeletePolicy(&iam.DeletePolicyInput{PolicyArn: p.Arn})
+							if err != nil {
+								By(fmt.Sprintf("failed to delete policy '%s'; reason: %s", policy.Description, err.Error()))
+							}
 							return awserrors.IsNotFound(err) || err == nil
 						}, 5*time.Minute, 5*time.Second).Should(BeTrue())
 						// TODO: why is there a break here? Don't we want to clean up everything?

test/e2e/shared/suite.go

@@ -130,7 +130,10 @@ func Node1BeforeSuite(e2eCtx *E2EContext) []byte {
 	e2eCtx.CloudFormationTemplate = renderCustomCloudFormation(bootstrapTemplate)
 
 	if !e2eCtx.Settings.SkipCloudFormationCreation {
+		count := 0
 		Eventually(func(gomega Gomega) bool {
+			count++
+			By(fmt.Sprintf("Trying to create CloudFormation stack... attempt %d", count))
 			success := true
 			if err := createCloudFormationStack(e2eCtx.AWSSession, bootstrapTemplate, bootstrapTags); err != nil {
 				deleteCloudFormationStack(e2eCtx.AWSSession, bootstrapTemplate)