Skip to content

Commit 85ead9e

Browse files
authored
Merge pull request #3920 from Ankitasw/capi-bump
chore: Bump CAPI to v1.3.1
2 parents d3a3fe9 + d42ffb8 commit 85ead9e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+729
-706
lines changed

.github/workflows/dependabot.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Set up Go 1.x
2222
uses: actions/setup-go@v3
2323
with:
24-
go-version: '1.18'
24+
go-version: '1.19'
2525
id: go
2626
- name: Check out code into the Go module directory
2727
uses: actions/[email protected]

.golangci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ linters-settings:
150150
- pkg: "sigs.k8s.io/cluster-api/exp/api/v1beta1"
151151
alias: expclusterv1
152152
staticcheck:
153-
go: "1.18"
153+
go: "1.19"
154154
stylecheck:
155-
go: "1.18"
155+
go: "1.19"
156156
issues:
157157
max-same-issues: 0
158158
max-issues-per-linter: 0

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# limitations under the License.
1616

1717
# Build the manager binary
18-
FROM golang:1.18.3 as toolchain
18+
FROM golang:1.19.4 as toolchain
1919

2020
# Run this with docker build --build_arg $(go env GOPROXY) to override the goproxy
2121
ARG goproxy=https://proxy.golang.org

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ ifeq ($(findstring \[PR-Blocking\],$(E2E_FOCUS)),\[PR-Blocking\])
143143
endif
144144

145145
override E2E_ARGS += -artifacts-folder="$(ARTIFACTS)" --data-folder="$(E2E_DATA_DIR)" -use-existing-cluster=$(USE_EXISTING_CLUSTER)
146-
override GINKGO_ARGS += -stream -progress -v -trace
146+
override GINKGO_ARGS += -v --trace --timeout=3h --output-dir="$(ARTIFACTS)" --junit-report="junit.e2e_suite.xml"
147147

148148
ifdef GINKGO_SKIP
149149
override GINKGO_ARGS += -skip "$(GINKGO_SKIP)"

api/v1beta2/suite_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,11 @@ import (
2121
"path"
2222
"testing"
2323

24-
. "github.com/onsi/ginkgo"
24+
. "github.com/onsi/ginkgo/v2"
2525
. "github.com/onsi/gomega"
2626
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
2727
"k8s.io/client-go/kubernetes/scheme"
2828
ctrl "sigs.k8s.io/controller-runtime"
29-
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
3029

3130
"sigs.k8s.io/cluster-api-provider-aws/v2/test/helpers"
3231
)
@@ -39,9 +38,7 @@ var (
3938
func TestAPIs(t *testing.T) {
4039
RegisterFailHandler(Fail)
4140

42-
RunSpecsWithDefaultAndCustomReporters(t,
43-
"Controller Suite",
44-
[]Reporter{printer.NewlineReporter{}})
41+
RunSpecs(t, "Controller Suite")
4542
}
4643

4744
func TestMain(m *testing.M) {

controllers/awsmachine_controller_unit_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import (
2626

2727
"github.com/aws/aws-sdk-go/aws"
2828
"github.com/golang/mock/gomock"
29-
. "github.com/onsi/ginkgo"
29+
. "github.com/onsi/ginkgo/v2"
3030
. "github.com/onsi/gomega"
3131
. "github.com/onsi/gomega/gstruct"
3232
"github.com/pkg/errors"

docs/book/src/development/development.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
### Install prerequisites
66

77
1. Install [go][go]
8-
- Get the latest patch version for go v1.18.
8+
- Get the latest patch version for go v1.19.
99
2. Install [jq][jq]
1010
- `brew install jq` on macOS.
1111
- `chocolatey install jq` on Windows.

docs/book/src/topics/machinepools.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Make sure to set up your AWS environment as described [here](https://cluster-api
2020
```shell
2121
export EXP_MACHINE_POOL=true
2222
clusterctl init --infrastructure aws
23-
clusterctl generate cluster my-cluster --kubernetes-version v1.24.0 --flavor machinepool > my-cluster.yaml
23+
clusterctl generate cluster my-cluster --kubernetes-version v1.25.0 --flavor machinepool > my-cluster.yaml
2424
```
2525

2626
The template used for this [flavor](https://cluster-api.sigs.k8s.io/clusterctl/commands/generate-cluster.html#flavors) is located [here](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/templates/cluster-template-machinepool.yaml).
@@ -76,7 +76,7 @@ spec:
7676
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
7777
kind: AWSMachinePool
7878
name: capa-mp-0
79-
version: v1.24.0
79+
version: v1.25.0
8080
---
8181
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
8282
kind: AWSMachinePool
@@ -136,7 +136,7 @@ spec:
136136
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
137137
kind: AWSMachinePool
138138
name: capa-mp-0
139-
version: v1.24.0
139+
version: v1.25.0
140140
```
141141

142142
When using GitOps, make sure to ignore differences in `spec.replicas` on MachinePools. Example when using ArgoCD:

docs/triage-party/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# limitations under the License.
1616

1717

18-
FROM golang:1.18.3 as builder
18+
FROM golang:1.19.4 as builder
1919

2020
RUN go get github.com/google/triage-party/cmd/server
2121
RUN go install github.com/google/triage-party/cmd/server@latest

docs/triage-party/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module triage-party-deployment
22

3-
go 1.18
3+
go 1.19
44

55
require (
66
github.com/aws/aws-cdk-go/awscdk v1.110.0-devpreview

0 commit comments

Comments
 (0)