Skip to content

Commit 9629087

Browse files
committed
fixed rosamachinepools rbac
- fixed docs
1 parent 238b63b commit 9629087

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

config/rbac/role.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ rules:
401401
- apiGroups:
402402
- infrastructure.cluster.x-k8s.io
403403
resources:
404-
- rosamachinenepools
404+
- rosamachinepools
405405
verbs:
406406
- delete
407407
- get
@@ -412,7 +412,7 @@ rules:
412412
- apiGroups:
413413
- infrastructure.cluster.x-k8s.io
414414
resources:
415-
- rosamachinenepools/status
415+
- rosamachinepools/status
416416
verbs:
417417
- get
418418
- patch

docs/book/src/topics/rosa/creating-a-cluster.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ CAPA controller requires an API token in order to be able to provision ROSA clus
1111
--from-literal=ocmToken='eyJhbGciOiJIUzI1NiIsI....' \
1212
--from-literal=ocmApiUrl='https://api.openshift.com'
1313
```
14-
14+
1515
Alternatively, you can edit CAPA controller deployment to provide the credentials:
1616
```shell
1717
kubectl edit deployment -n capa-system capa-controller-manager
@@ -36,7 +36,7 @@ Once Step 3 is done, you will be ready to proceed with creating a ROSA cluster u
3636

3737
1. Prepare the environment:
3838
```bash
39-
export OPENSHIFT_VERSION="openshift-v4.14.5"
39+
export OPENSHIFT_VERSION="4.14.5"
4040
export CLUSTER_NAME="capi-rosa-quickstart"
4141
export AWS_REGION="us-west-2"
4242
export AWS_AVAILABILITY_ZONE="us-west-2a"

exp/controllers/rosamachinepool_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ func (r *ROSAMachinePoolReconciler) SetupWithManager(ctx context.Context, mgr ct
6969
// +kubebuilder:rbac:groups=cluster.x-k8s.io,resources=machinepools;machinepools/status,verbs=get;list;watch;patch
7070
// +kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;patch
7171
// +kubebuilder:rbac:groups=controlplane.cluster.x-k8s.io,resources=rosacontrolplanes;rosacontrolplanes/status,verbs=get;list;watch
72-
// +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=rosamachinenepools,verbs=get;list;watch;update;patch;delete
73-
// +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=rosamachinenepools/status,verbs=get;update;patch
72+
// +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=rosamachinepools,verbs=get;list;watch;update;patch;delete
73+
// +kubebuilder:rbac:groups=infrastructure.cluster.x-k8s.io,resources=rosamachinepools/status,verbs=get;update;patch
7474

7575
// Reconcile reconciles RosaMachinePool.
7676
func (r *ROSAMachinePoolReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Result, reterr error) {

templates/cluster-template-rosa-machinepool.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,16 @@ spec:
6767
infrastructureRef:
6868
name: "${CLUSTER_NAME}-pool-0"
6969
apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
70-
kind: RosaMachinePool
70+
kind: ROSAMachinePool
7171
---
7272
apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
73-
kind: RosaMachinePool
73+
kind: ROSAMachinePool
7474
metadata:
7575
name: "${CLUSTER_NAME}-pool-0"
7676
spec:
7777
nodePoolName: "nodepool-0"
7878
instanceType: "m5.xlarge"
7979
subnet: "${PRIVATE_SUBNET_ID}"
80+
version: "${OPENSHIFT_VERSION}"
8081

8182

0 commit comments

Comments
 (0)