Skip to content

Commit 99b4d7a

Browse files
authored
Merge pull request #5079 from richardcase/new_issue_templates
🌱 feat: add issue templates for reviewers/maintainer changes
2 parents 3117e8e + b32ec96 commit 99b4d7a

File tree

2 files changed

+110
-0
lines changed

2 files changed

+110
-0
lines changed
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
name: Add or remove maintainer
2+
description: To be used when making changes to project maintainers. See [contributing guide(https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/CONTRIBUTING.md)] for details of the projects ladder.
3+
labels: ["kind/support"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
Use this form to make changes to the maintainers of CAPA
9+
- type: input
10+
id: github_handle
11+
attributes:
12+
label: GitHub handle
13+
description: The GitHub handle of the maintainer that changes will be made to.
14+
validations:
15+
required: true
16+
- type: dropdown
17+
id: action
18+
attributes:
19+
label: Action
20+
description: What action is being performed to the maintainers
21+
options:
22+
- Add
23+
- Remove
24+
validations:
25+
required: true
26+
- type: input
27+
id: merge_date
28+
attributes:
29+
label: Merge date
30+
description: Enter the date when the changes can merge. The date should be 7 days or after the next CAPA office hours (whichever is longer)
31+
validations:
32+
required: true
33+
- type: textarea
34+
id: reason
35+
attributes:
36+
label: Reason for change
37+
description: What is the reason this change is being made
38+
validations:
39+
required: true
40+
- type: textarea
41+
id: tasks
42+
attributes:
43+
label: 🖱️Tasks
44+
value: |
45+
```[tasklist]
46+
## Tasks to be done
47+
- [ ] Update **cluster-api-aws-maintainers** section in [OWNER_ALIASES](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/OWNERS_ALIASES) in CAPA repo
48+
- [ ] Create a PR with the change and add `/hold`
49+
- [ ] Announce the change in the CAPA slack channel
50+
- [ ] Add PSA in the notes doc for the next CAPA office hours
51+
- [ ] After the lazy consensus review period remove the hold
52+
- [ ] Update **cluster-api-provider-aws-maintainers** team in [this file](https://github.com/kubernetes/org/blob/main/config/kubernetes-sigs/sig-cluster-lifecycle/teams.yaml)
53+
- [ ] Update **approvers** for CAPA jobs [here](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-aws/OWNERS)
54+
- [ ] Update **approvers** from CAPA image promotion [here](https://github.com/kubernetes/k8s.io/blob/main/registry.k8s.io/images/k8s-staging-cluster-api-aws/OWNERS)
55+
- [ ] Update **[email protected]** [here](https://github.com/kubernetes/k8s.io/blob/main/groups/sig-cluster-lifecycle/groups.yaml)
56+
- [ ] Update **[email protected]** [here](https://github.com/kubernetes/k8s.io/blob/main/groups/sig-cluster-lifecycle/groups.yaml)
57+
```
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
name: Add or remove reviewer
2+
description: To be used when making changes to project reviewers. See [contributing guide(https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/CONTRIBUTING.md)] for details of the projects ladder.
3+
labels: ["kind/support"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
Use this form to make changes to the reviewers of CAPA
9+
- type: input
10+
id: github_handle
11+
attributes:
12+
label: GitHub handle
13+
description: The GitHub handle of the reviewer that changes will be made to.
14+
validations:
15+
required: true
16+
- type: dropdown
17+
id: action
18+
attributes:
19+
label: Action
20+
description: What action is being performed to the reviewers
21+
options:
22+
- Add
23+
- Remove
24+
validations:
25+
required: true
26+
- type: input
27+
id: merge_date
28+
attributes:
29+
label: Merge date
30+
description: Enter the date when the changes can merge. The date should be 7 days or after the next CAPA office hours (whichever is longer)
31+
validations:
32+
required: true
33+
- type: textarea
34+
id: reason
35+
attributes:
36+
label: Reason for change
37+
description: What is the reason this change is being made
38+
validations:
39+
required: true
40+
- type: textarea
41+
id: tasks
42+
attributes:
43+
label: 🖱️Tasks
44+
value: |
45+
```[tasklist]
46+
## Tasks to be done
47+
- [ ] Update **cluster-api-aws-reviewers** section in [OWNER_ALIASES](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/OWNERS_ALIASES) in CAPA repo
48+
- [ ] Create a PR with the change and add `/hold`
49+
- [ ] Announce the change in the CAPA slack channel
50+
- [ ] Add PSA in the notes doc for the next CAPA office hours
51+
- [ ] After the lazy consensus review period remove the hold
52+
- [ ] Update **reviewers** for CAPA jobs [here](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-aws/OWNERS)
53+
```

0 commit comments

Comments
 (0)