Skip to content

Commit a6a967c

Browse files
k8s-ci-robotk8s-ci-robot
authored
Merge pull request #3413 from sedefsavas/remove-listwebhooks
Remove list webhooks
2 parents 7a545cd + 7b83ba8 commit a6a967c

12 files changed

+75
-190
lines changed

‎api/v1alpha3/webhook_suite_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,6 @@ func setup() {
7777
if err := (&infrav1.AWSMachineTemplate{}).SetupWebhookWithManager(testEnv); err != nil {
7878
panic(fmt.Sprintf("Unable to setup AWSMachineTemplate webhook: %v", err))
7979
}
80-
if err := (&infrav1.AWSMachineList{}).SetupWebhookWithManager(testEnv); err != nil {
81-
panic(fmt.Sprintf("Unable to setup AWSMachineList webhook: %v", err))
82-
}
8380
go func() {
8481
fmt.Println("Starting the manager")
8582
if err := testEnv.StartManager(ctx); err != nil {

‎api/v1beta1/awsclustercontrolleridentitylist_webhook.go

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎api/v1beta1/awsclusterlist_webhook.go

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎api/v1beta1/awsclusterroleidentitylist_webhook.go

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎api/v1beta1/awsmachinelist_webhook.go

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎api/v1beta1/awsmachinetemplatelist_webhook.go

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎api/v1beta1/suite_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,6 @@ func setup() {
7070
if err := (&AWSMachineTemplate{}).SetupWebhookWithManager(testEnv); err != nil {
7171
panic(fmt.Sprintf("Unable to setup AWSMachineTemplate webhook: %v", err))
7272
}
73-
if err := (&AWSMachineList{}).SetupWebhookWithManager(testEnv); err != nil {
74-
panic(fmt.Sprintf("Unable to setup AWSMachineList webhook: %v", err))
75-
}
7673
if err := (&AWSClusterControllerIdentity{}).SetupWebhookWithManager(testEnv); err != nil {
7774
panic(fmt.Sprintf("Unable to setup AWSClusterControllerIdentity webhook: %v", err))
7875
}

‎controllers/suite_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ func setup() {
6363
if err := (&infrav1.AWSMachineTemplate{}).SetupWebhookWithManager(testEnv); err != nil {
6464
panic(fmt.Sprintf("Unable to setup AWSMachineTemplate webhook: %v", err))
6565
}
66-
if err := (&infrav1.AWSMachineList{}).SetupWebhookWithManager(testEnv); err != nil {
67-
panic(fmt.Sprintf("Unable to setup AWSMachineList webhook: %v", err))
68-
}
6966
if err := (&infrav1.AWSClusterControllerIdentity{}).SetupWebhookWithManager(testEnv); err != nil {
7067
panic(fmt.Sprintf("Unable to setup AWSClusterControllerIdentity webhook: %v", err))
7168
}

‎docs/book/src/crd/index.md

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19172,6 +19172,21 @@ ManagedMachinePoolCapacityType
1917219172
<p>CapacityType specifies the capacity type for the ASG behind this pool</p>
1917319173
</td>
1917419174
</tr>
19175+
<tr>
19176+
<td>
19177+
<code>updateConfig</code><br/>
19178+
<em>
19179+
<a href="#infrastructure.cluster.x-k8s.io/v1beta1.UpdateConfig">
19180+
UpdateConfig
19181+
</a>
19182+
</em>
19183+
</td>
19184+
<td>
19185+
<em>(Optional)</em>
19186+
<p>UpdateConfig holds the optional config to control the behaviour of the update
19187+
to the nodegroup.</p>
19188+
</td>
19189+
</tr>
1917519190
</table>
1917619191
</td>
1917719192
</tr>
@@ -19420,6 +19435,21 @@ ManagedMachinePoolCapacityType
1942019435
<p>CapacityType specifies the capacity type for the ASG behind this pool</p>
1942119436
</td>
1942219437
</tr>
19438+
<tr>
19439+
<td>
19440+
<code>updateConfig</code><br/>
19441+
<em>
19442+
<a href="#infrastructure.cluster.x-k8s.io/v1beta1.UpdateConfig">
19443+
UpdateConfig
19444+
</a>
19445+
</em>
19446+
</td>
19447+
<td>
19448+
<em>(Optional)</em>
19449+
<p>UpdateConfig holds the optional config to control the behaviour of the update
19450+
to the nodegroup.</p>
19451+
</td>
19452+
</tr>
1942319453
</tbody>
1942419454
</table>
1942519455
<h3 id="infrastructure.cluster.x-k8s.io/v1beta1.AWSManagedMachinePoolStatus">AWSManagedMachinePoolStatus
@@ -20428,4 +20458,49 @@ string
2042820458
<p>
2042920459
<p>Taints is an array of Taints.</p>
2043020460
</p>
20461+
<h3 id="infrastructure.cluster.x-k8s.io/v1beta1.UpdateConfig">UpdateConfig
20462+
</h3>
20463+
<p>
20464+
(<em>Appears on:</em><a href="#infrastructure.cluster.x-k8s.io/v1beta1.AWSManagedMachinePoolSpec">AWSManagedMachinePoolSpec</a>)
20465+
</p>
20466+
<p>
20467+
<p>UpdateConfig is the configuration options for updating a nodegroup. Only one of MaxUnavailable
20468+
and MaxUnavailablePercentage should be specified.</p>
20469+
</p>
20470+
<table>
20471+
<thead>
20472+
<tr>
20473+
<th>Field</th>
20474+
<th>Description</th>
20475+
</tr>
20476+
</thead>
20477+
<tbody>
20478+
<tr>
20479+
<td>
20480+
<code>maxUnavailable</code><br/>
20481+
<em>
20482+
int
20483+
</em>
20484+
</td>
20485+
<td>
20486+
<em>(Optional)</em>
20487+
<p>MaxUnavailable is the maximum number of nodes unavailable at once during a version update.
20488+
Nodes will be updated in parallel. The maximum number is 100.</p>
20489+
</td>
20490+
</tr>
20491+
<tr>
20492+
<td>
20493+
<code>maxUnavailablePrecentage</code><br/>
20494+
<em>
20495+
int
20496+
</em>
20497+
</td>
20498+
<td>
20499+
<em>(Optional)</em>
20500+
<p>MaxUnavailablePercentage is the maximum percentage of nodes unavailable during a version update. This
20501+
percentage of nodes will be updated in parallel, up to 100 nodes at once.</p>
20502+
</td>
20503+
</tr>
20504+
</tbody>
20505+
</table>
2043120506
<hr/>

‎exp/controllers/suite_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,6 @@ func setup() {
7070
if err := (&infrav1.AWSMachineTemplate{}).SetupWebhookWithManager(testEnv); err != nil {
7171
panic(fmt.Sprintf("Unable to setup AWSMachineTemplate webhook: %v", err))
7272
}
73-
if err := (&infrav1.AWSMachineList{}).SetupWebhookWithManager(testEnv); err != nil {
74-
panic(fmt.Sprintf("Unable to setup AWSMachineList webhook: %v", err))
75-
}
7673
if err := (&expinfrav1.AWSMachinePool{}).SetupWebhookWithManager(testEnv); err != nil {
7774
panic(fmt.Sprintf("Unable to setup AWSMachinePool webhook: %v", err))
7875
}

0 commit comments

Comments
 (0)