set NotReady if cluster was automatically upgraded

Author: phuhung273

pkg/cloud/services/eks/cluster.go

@@ -145,23 +145,7 @@ func (s *Service) reconcileCluster(ctx context.Context) error {
 // computeCurrentStatusVersion returns the computed current EKS cluster kubernetes version.
 // The computation has awareness of the fact that EKS clusters only return a major.minor kubernetes version,
 // and returns a compatible version for te status according to the one the user specified in the spec.
-func computeCurrentStatusVersion(specV *string, clusterV *string) *string {
-	specVersion := ""
-	if specV != nil {
-		specVersion = *specV
-	}
-
-	clusterVersion := ""
-	if clusterV != nil {
-		clusterVersion = *clusterV
-	}
-
-	// Ignore parsing errors as these are already validated by the kubebuilder validation and the AWS API.
-	// Also specVersion might not be specified in the spec.Version for AWSManagedControlPlane, this results in a "0.0.0" version.
-	// Also clusterVersion might not yet be returned by the AWS EKS API, as the cluster might still be initializing, this results in a "0.0.0" version.
-	specSemverVersion, _ := semver.ParseTolerant(specVersion)
-	currentSemverVersion, _ := semver.ParseTolerant(clusterVersion)
-
+func computeCurrentStatusVersion(clusterV *string, specSemverVersion semver.Version, currentSemverVersion semver.Version) *string {
 	// If AWS EKS API is not returning a version, set the status.Version to empty string.
 	if currentSemverVersion.String() == "0.0.0" {
 		return ptr.To("")
@@ -185,9 +169,27 @@ func computeCurrentStatusVersion(specV *string, clusterV *string) *string {
 	return clusterV
 }
 
+// parseClusterVersionString parse a version string to semver version
+// If the string cannot be parsed to semver, returning 0.0.0
+func parseClusterVersionString(str *string) semver.Version {
+	version := ""
+	if str != nil {
+		version = *str
+	}
+
+	// Ignore parsing errors as these are already validated by the kubebuilder validation and the AWS API.
+	semverVersion, _ := semver.ParseTolerant(version)
+	return semverVersion
+}
+
 func (s *Service) setStatus(cluster *ekstypes.Cluster) error {
+	// specSemver might not be specified in the spec.Version for AWSManagedControlPlane, this results in a "0.0.0" version.
+	specSemver := parseClusterVersionString(s.scope.ControlPlane.Spec.Version)
+	// clusterSemver might not yet be returned by the AWS EKS API, as the cluster might still be initializing, this results in a "0.0.0" version.
+	clusterSemver := parseClusterVersionString(cluster.Version)
+
 	// Set the current Kubernetes control plane version in the status.
-	s.scope.ControlPlane.Status.Version = computeCurrentStatusVersion(s.scope.ControlPlane.Spec.Version, cluster.Version)
+	s.scope.ControlPlane.Status.Version = computeCurrentStatusVersion(cluster.Version, specSemver, clusterSemver)
 
 	// Set the current cluster status in the control plane status.
 	switch cluster.Status {
@@ -209,6 +211,18 @@ func (s *Service) setStatus(cluster *ekstypes.Cluster) error {
 			conditions.MarkFalse(s.scope.ControlPlane, ekscontrolplanev1.EKSControlPlaneUpdatingCondition, "updated", clusterv1.ConditionSeverityInfo, "")
 			record.Eventf(s.scope.ControlPlane, "SuccessfulUpdateEKSControlPlane", "Updated EKS control plane %s", s.scope.KubernetesClusterName())
 		}
+		if s.scope.ControlPlane.Spec.UpgradePolicy == ekscontrolplanev1.UpgradePolicyStandard &&
+			(specSemver.Major < clusterSemver.Major || specSemver.Minor < clusterSemver.Minor) {
+			s.scope.ControlPlane.Status.Ready = false
+			failureMsg := fmt.Sprintf(
+				"EKS control plane %s was automatically upgraded to version %s because %s is out of standard support. "+
+					"This can be fixed by bumping to the actual version of the cluster",
+				s.scope.KubernetesClusterName(),
+				clusterSemver.String(),
+				specSemver.String(),
+			)
+			s.scope.ControlPlane.Status.FailureMessage = &failureMsg
+		}
 		// TODO FailureReason
 	case ekstypes.ClusterStatusCreating:
 		s.scope.ControlPlane.Status.Ready = false